-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings rework #249
Settings rework #249
Conversation
Alright, figured out why those two tests failed: The settings as initialized by the test_settings script are not using the pytest_project project but are instead using the 'empty' default project, meaning the |
# Conflicts: # activity_browser/app/ui/tabs/activity.py
Closing this as another pull-request has already implemented it. |
Some initial work on issue #106.
I've added variable typing to the settings classes and implemented functions from the
commontasks.py
file in the relevant settings classes.While not quite the same as how sublime handles the settings files (no comments explaining the settings inside the file, etc.) I think this implementation does allow for ease of adding settings later on.
I anyone has suggestions for improvement please add them :)