Code

Settings rework#249

Code

Closed

dgdekoning wants to merge 21 commits intoLCA-ActivityBrowser:masterLCA-ActivityBrowser/activity-browser:masterfrom dgdekoning:settings-reworkCopy head branch name to clipboard

+892-239

Commits

Commits on Jun 17, 2019

• Create base settings class

  dgdekoning

  committed
  1a8268e

• Implement BaseSettings in ABSettings, add typing

  dgdekoning

  committed
  883d347

• Implement BaseSettings in ProjectSettings class

  dgdekoning

  committed
  604d61e

• Update SettingsWizard to use ab_settings correctly

  dgdekoning

  committed
  202c821

• Replace commontasks workarounds with direct settings calls

  dgdekoning

  committed
  c418c17

• Added note warning, remove these functions later

  dgdekoning

  committed
  92d162c

• Add catch for handling of deleted projects

  dgdekoning

  committed
  7ff5bac

Commits on Jul 16, 2019

• Add more typing and add project-specific biosphere types setting

  dgdekoning

  committed
  5eb296c

• Implement settings lookup for biosphere types

  dgdekoning

  committed
  8e8c52b

Commits on Jul 17, 2019

• Refactor last call to commontasks and remove duplicate setting-specific methods

  dgdekoning

  committed
  ceffc83

Commits on Jul 18, 2019

• Add method for validating a list of possible biosphere types

  dgdekoning

  committed
  254d209

• Completely rewrite settings wizard to allow user to set project settings

  dgdekoning

  committed
  7694e70

• Add restore_defaults for project and ensure clear and up-to-date values

  dgdekoning

  committed
  2064dc4

Commits on Jul 26, 2019

• Make default settings a classmethod, add tests for settings classes

  dgdekoning

  committed
  3c7f2eb

• Cannot expect list from dict-keys to be ordered

  dgdekoning

  committed
  66db2b8

• Found the actual issue with incorrect default setting construction

  dgdekoning

  committed
  e0e554d

• Split the settings tests into many smaller, more unit-like tests

  dgdekoning

  committed
  b0cedb3

• No idea why the tests failed, but here is a fix.

  dgdekoning

  committed
  8079e88

Commits on Jul 31, 2019

• Add clear call so that setText triggers textChanged signal

  dgdekoning

  committed
  3071859

• Add tests for the revamped settings wizard

  dgdekoning

  committed
  bdf8186

• Merge branch 'master' into settings-rework

  Show description for 6a68431
  dgdekoning

  committed
  6a68431