Prepwork pyside2 refactor #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsteubing
pushed a commit
that referenced
this pull request
Nov 4, 2019
* Prepwork pyside2 refactor (#311) * Refactor code to use PySide signal/slot nomenclature * Use button reference instead of integer * Remove QVariant references * Replace PyQt5 with PySide2 Change 'flags' to 'f' for compatibility * Change menu.exec to menu.exec_ for compatibility * Specify setCheckState for compatibility * Change recipe files to use pyside2 * Update automation pipeline scripts * [skip ci] Clean-up imports * [skip ci] Missed an exec to exec_ change * [skip ci] Change licence from GPL to LGPL (#313) * Replace GPL3 license file with LGPL3 * Update references to the license * Add myself as main developer * Update texts for CONTRIBUTING.md to reflect previous pytest changes * Update README create/install commands to prefer conda-forge channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare code for refactoring to pyside2 (#184).
These changes clear up PyQt specific naming and drops the use of QVariant.
No functional changes are made.