Pyside2 Refactor #315
Merged
Pyside2 Refactor #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor code to use PySide signal/slot nomenclature * Use button reference instead of integer * Remove QVariant references
Change 'flags' to 'f' for compatibility
* Replace PyQt5 with PySide2 * Change `flags` to `f` for compatibility * Change `exec` to `exec_` for compatibility * Specify `setCheckState` for compatibility * Change recipe files to use pyside2 * Update automation pipeline scripts * Clean-up unused pyside2 imports
* Replace GPL3 license file with LGPL3 * Update references to the license * Add myself as main developer * Update texts for CONTRIBUTING.md to reflect previous pytest changes * Update README create/install commands to prefer conda-forge channel
# Conflicts: # activity_browser/app/ui/menu_bar.py # activity_browser/app/ui/tables/activity.py
bsteubing
approved these changes
Nov 4, 2019
|
Nice job - thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #184.
Replaces PyQt5 with PySide2 to allow for LGPL license.
Moving to a newer version of Qt might also resolve a number of Qt-related issues (#286, #288).