Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Handle buttons "focus" style correctly #3127

Closed
korhaliv opened this issue Nov 6, 2019 · 1 comment
Closed

Handle buttons "focus" style correctly #3127

korhaliv opened this issue Nov 6, 2019 · 1 comment
Assignees
@korhaliv
Labels
scope: ui/ux issues with user interface or user experience in general type: bug 🐛 Something isn't working
Milestone
v0.6.0-beta

Comments

@korhaliv
Copy link
Member

korhaliv commented Nov 6, 2019

Description

Currently when you click a button it goes into "focus" state and stays as such until you click outside.
This can cause minor visual glitches when using buttons as dropdown toggles etc. The offending style is located in base.js for next and themes/utils.js for master
@korhaliv korhaliv added this to the v0.6.0-beta milestone Nov 6, 2019
@mrfelton mrfelton added type: bug 🐛 Something isn't working scope: ui/ux issues with user interface or user experience in general labels Nov 6, 2019
korhaliv added a commit to korhaliv/zap-desktop that referenced this issue Nov 8, 2019
@korhaliv
fix(ui): only focus elements when they receive it through tab
f9b5da1 
resolves LN-Zap#3127
@korhaliv korhaliv mentioned this issue Nov 8, 2019
Merged
6 tasks
@mrfelton
Copy link
Member

mrfelton commented Nov 8, 2019

Closed via #3143

@mrfelton mrfelton closed this as completed Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@korhaliv korhaliv

Labels
scope: ui/ux issues with user interface or user experience in general type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.6.0-beta
Development

No branches or pull requests
2 participants
@mrfelton @korhaliv