This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix components focus issue #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Resolves #3127
Motivation and Context:
Currently we use
:focusselector to described focused state for components. This is used for accessibility support. The side effect is that components also transition to a focused state on click, which causes visual issues in some cases. This pr solves the issue by leveragingfocus-visiblepseudostyle polyfill which was specifically designed to handle such cases.How Has This Been Tested?
Manually
Types of changes:
Bugfix
Checklist: