Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Retried failed payment stuck in processing state #3142

Closed
mrfelton opened this issue Nov 8, 2019 · 0 comments · Fixed by #3145
Closed

Retried failed payment stuck in processing state #3142

mrfelton opened this issue Nov 8, 2019 · 0 comments · Fixed by #3145
Assignees
@mrfelton
Labels
type: bug 🐛 Something isn't working
Milestone
v0.6.0-beta

Comments

@mrfelton
Copy link
Member

mrfelton commented Nov 8, 2019

Description

Retried failed payment stuck in processing state

Expected Behavior

If you retry a failed payment and it also fails the second time the second attempt should be marked as failed just like the first one is.

Actual Behavior

The second failed payment attempt gets stick in payments sending state.

Possible Fix

Adjust payments sending logic

Steps to Reproduce

  1. Create an LN invoice
  2. Try to pay your own invoice - after 3 failed attempts it gets marked as failed
  3. Try to pay the same invoice again - this time it gets stuck in sending state
@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Nov 8, 2019
@mrfelton mrfelton added this to the v0.6.0-beta milestone Nov 8, 2019
@mrfelton mrfelton self-assigned this Nov 8, 2019
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Nov 8, 2019
@mrfelton
fix(ui): ensure failed payments marked as failed
a06e29b 
Generate a unique payment id for sending payments to enable more
accurate tracking of payments across retry attempts.

Fix LN-Zap#3142
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Nov 8, 2019
@mrfelton
fix(ui): ensure failed payments marked as failed
d87618e 
Generate a unique payment id for sending payments to enable more
accurate tracking of payments across retry attempts.

Fix LN-Zap#3142
@mrfelton mrfelton mentioned this issue Nov 8, 2019
Merged
6 tasks
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Nov 8, 2019
@mrfelton
fix(ui): ensure failed payments marked as failed
6c79a0f 
Generate a unique payment id for sending payments to enable more
accurate tracking of payments across retry attempts.

Fix LN-Zap#3142
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Nov 8, 2019
@mrfelton
fix(ui): ensure failed payments marked as failed
a0488d1 
Generate a unique payment id for sending payments to enable more
accurate tracking of payments across retry attempts.

Fix LN-Zap#3142
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Nov 9, 2019
@mrfelton
fix(ui): ensure failed payments marked as failed
c734b87 
Generate a unique payment id for sending payments to enable more
accurate tracking of payments across retry attempts.

Fix LN-Zap#3142
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrfelton mrfelton

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.6.0-beta
Development

Successfully merging a pull request may close this issue.

Ensure failed payments marked as failed mrfelton/zap-desktop
1 participant
@mrfelton