This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Ensure failed payments marked as failed #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
force-pushed
the
fix/payments-sending
branch
from
d87618e to
6c79a0f
Compare
mrfelton
force-pushed
the
fix/payments-sending
branch
from
6c79a0f to
a0488d1
Compare
korhaliv
previously requested changes
Nov 9, 2019
| grpcLog.error('PAYMENT ERROR', res) | ||
| const error = new Error(res.payment_error) | ||
| error.details = res | ||
| reject(error) |
There was a problem hiding this comment.
Is there a reason why here we reject and in catch we re-throw?
There was a problem hiding this comment.
The rejection here is used to reject the Promise within the data event handler in the case that the sendPayment lightning call returns an error (which it does by returning a success but with payment_error set).
The catch at the end wraps the entire method and is triggered in the event that an unexpected error occurs anywhere within our sendPayment wrapper. It doesn't re throw the rejection from the data event handler.
Generate a unique payment id for sending payments to enable more accurate tracking of payments across retry attempts. Fix LN-Zap#3142
mrfelton
force-pushed
the
fix/payments-sending
branch
from
e55c00f to
f1600d1
Compare
korhaliv
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ensure failed payments marked as failed
Generate a unique payment id for sending payments to enable more accurate tracking of payments across retry attempts.
Motivation and Context:
Fix #3142
How Has This Been Tested?
Manually
Types of changes:
Fix
Checklist: