Replace buildDir with layout.buildDirectory and do some other housekeeping

[labkey-susanh]

Rationale

In Gradle 8.3, the use of project.buildDir was deprecated in favor of project.layout.buildDirectory. We make adjustments here to upgrade to the new world order. We also take this opportunity to do a little housecleaning of a good number of stray semicolons that are cluttering the space and to replace almost all remaining usages of task.findTaskByName with task.named.

Related Pull Requests

Changes

• Issue 49045 - make copying to the modules-api directory a proper task, so it can run even if apiJar does not
• Eliminate usages of deprecated project.buildDir
• Update BuildUtils.includeModules to be able to specify full module paths for exclusion, not just directory names

[labkey-tchad]

Submitting a partial review because some of these path differences seem like they might break things.

[labkey-tchad]

For places that could work with any of project.layout.buildDirectory.file("file"), BuildUtils.getBuildDirFile(project, "file"), or a String; is there an order of preference to which one to use?

[labkey-tchad]

For Distribution.getArtifactId

    static Optional<TaskProvider> getOptionalTask(Project project, String taskName)
    {
        try {
            return Optional.of(project.tasks.named(taskName))
        }
        catch (UnknownTaskException ignore) {
            return Optional.empty()
        }
    }

[labkey-susanh]

For places that could work with any of project.layout.buildDirectory.file("file"), BuildUtils.getBuildDirFile(project, "file"), or a String; is there an order of preference to which one to use?

I tend to prefer the provider version if I know that it will work, simply because it seems to be the way Gradle is heading, but I also don't think it matters much. It annoys me that it's not at all obvious in various places where the string is needed vs. the file vs. the provider. I'm pretty sure the ant builder interface requires strings most of the time, for example.

[labkey-tchad]

Looks good. I just pushed a change to remove TaskUtils.getFromTaskIfPresent. They aren't actually used and TaskUtils.getOptionalTask can accomplish the same thing.