Replace buildDir with layout.buildDirectory and add an excludedModules property
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
approved these changes
Nov 14, 2023
Comment on lines
+110
to
+113
| if (hasProperty('excludedModules')) | ||
| { | ||
| excludedModules.addAll("${excludedModules}".split(",")) | ||
| } |
There was a problem hiding this comment.
Could the BuildUtils.include* methods automatically check the excludedModules property instead of having to check it in every settings file?
There was a problem hiding this comment.
I tried that, but this hasProperty method always returns null inside the Gradle plugin. Not sure why, but I didn't want to spend more time fighting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In Gradle 8.3, the use of
project.buildDirwas deprecated in favor ofproject.layout.buildDirectory.Related Pull Requests
buildDirwithlayout.buildDirectoryand do some other housekeeping gradlePlugin#185Changes
excludeModulesthat allows specifying a full path to a module (or set of modules) to exclude