ISO 15897 format of country specific locales #1269

bjoerne2 · 2020-06-24T14:20:34Z

On https://laravel.com/docs/7.x/localization it says:

For languages that differ by territory, you should name the language directories according to the ISO 15897. For example, "en_GB" should be used for British English rather than "en-gb".

Wouldn't it be better to rename the country specific folders, e.g. de-CH -> de_CH?

caouecs · 2020-06-25T18:38:02Z

Good idea, we need to do a new major version ( v7 ), because we brake directory names...

Can you do a pull request ?

bjoerne2 · 2020-07-03T18:25:38Z

I created a PR: #1276

caouecs · 2020-07-08T09:01:13Z

Can I have references for language names ? As sr_Cyrl

caouecs · 2020-07-11T11:13:40Z

My problem is for sr_Cyrl, sr_Latn, uz_Cyrl and uz_Latn.

andrey-helldar · 2020-07-11T17:36:29Z

Either I read the technical documentation poorly, or in the description of the ISO 15897:1998 standard there is no mention of the rules for naming language localizations.
Standard ISO 15897:2011 is paid ($168...) 😐

I may be wrong, but I want to propose to call it this way:

de_CH
pt_BR
...
sr_Cyrillic
sr_Latin
uz_Cyrillic
uz_Latin

caouecs · 2020-07-13T19:03:25Z

done

Thank you

milose · 2020-11-24T19:37:46Z

If you list the php Intl locales, we have a specific list of locales and the naming should be followed.

 collect(ResourceBundle::getLocales(''))->filter(fn($i) => Str::startsWith($i, 'sr'))
=> Illuminate\Support\Collection {#3268
     all: [
       672 => "sr",
       673 => "sr_Cyrl",
       674 => "sr_Cyrl_BA",
       675 => "sr_Cyrl_ME",
       676 => "sr_Cyrl_RS",
       677 => "sr_Cyrl_XK",
       678 => "sr_Latn",
       679 => "sr_Latn_BA",
       680 => "sr_Latn_ME",
       681 => "sr_Latn_RS",
       682 => "sr_Latn_XK",
     ],
   }

Meaning that sr_Latin, me, etc; locale folders you have are invalid.

Note, I am from Montenegro and I use sr_Latn_ME nomenclature, when I develop.

andrey-helldar · 2020-11-24T21:18:25Z

@caouecs, Since the ISO 15897:2011 standard does not regulate the naming of these localizations, I think @milose's proposal is reasonable.

caouecs · 2020-11-25T20:23:27Z

no problem for me

andrey-helldar · 2020-11-25T22:27:56Z

no problem for me

I created a PR #1453, but @LukaLatkovic must review, since he is referent for the sr_* languages.

LukaLatkovic · 2020-11-26T13:22:41Z

So, that means that me folder should be renamed to sr_Latn_ME

LukaLatkovic · 2020-11-26T15:27:57Z

@caouecs, Since the ISO 15897:2011 standard does not regulate the naming of these localizations, I think @milose's proposal is reasonable.

This proposal is done by Unicode standard(International Components for Unicode), so maybe we can do locales based on that standard List of all locales by Unicode, Simple search since Php Intl is based on that
@caouecs, @andrey-helldar what do you think?

milose · 2020-11-26T22:57:09Z

We are web developers here and this is a Laravel oriented package. With this I mean to say that the directory of the locale should be named in a way so it can be consumed app()->getLocale() method.

Laravel workflow is:

you set the 'locale' in app.php
you use the <html lang="{{ str_replace('_', '-', app()->getLocale()) }}"> to set the language contained in your HTML output (important for search engines, automatic translations, screen readers etc.
you consume other packages with the correct locales like Carbon (their Lang folder) with ease.

Introducing other names, that are not standardised on the web means we need to "translate" locale names for other packages, html attributes etc. This is not ideal and the correct nomenclature should be used.

BTW, the translation for Montenegrin language is atrocious. I will make a pull request for the correct translation after this is resolved.

andrey-helldar · 2020-11-27T06:22:09Z

@caouecs, Since the ISO 15897:2011 standard does not regulate the naming of these localizations, I think @milose's proposal is reasonable.

This proposal is done by Unicode standard(International Components for Unicode), so maybe we can do locales based on that standard List of all locales by Unicode, Simple search since Php Intl is based on that
@caouecs, @andrey-helldar what do you think?

Taylor introduced the ISO 15897:2011 standard into the framework and I think we don't need to violate it.

If proposals for adjustments do not contradict him, then they can be considered.

milose · 2020-11-27T17:49:22Z

Taylor introduced the ISO 15897:2011 standard into the framework and I think we don't need to violate it.

Sauce, please? @andrey-helldar

andrey-helldar · 2020-11-27T18:31:51Z

Taylor introduced the ISO 15897:2011 standard into the framework and I think we don't need to violate it.

Sauce, please? @andrey-helldar

You mean proof?

And my PR: #1453

milose · 2020-11-30T07:52:12Z

Thanks @andrey-helldar I missed that.

andrey-helldar · 2020-12-04T10:11:29Z

@milose, a few days ago, we released a new major version of the package taking into account these changes.
You can independently monitor the update of files in your project or use a manager. For example, this one.

caouecs · 2020-12-04T12:47:47Z

@milose, a few days ago, we released a new major version of the package taking into account these changes.
You can independently monitor the update of files in your project or use a manager. For example, this one.

for example... ;)

bjoerne2 added a commit to bjoerne2/Laravel-lang that referenced this issue Jul 3, 2020

Laravel-Lang#1269 Rename locale folders following ISO 15897 format

7b62c30

bjoerne2 mentioned this issue Jul 3, 2020

#1269 Rename locale folders following ISO 15897 format #1276

Closed

caouecs assigned bjoerne2 Jul 8, 2020

caouecs added the question label Jul 8, 2020

caouecs linked a pull request Jul 8, 2020 that will close this issue

#1269 Rename locale folders following ISO 15897 format #1276

Closed

caouecs added this to the 7.0 milestone Jul 8, 2020

caouecs mentioned this issue Jul 13, 2020

Language names in translation publisher #1286

Closed

3 tasks

caouecs added a commit that referenced this issue Jul 13, 2020

feature: #1269 Rename locale folders following ISO 15897 format

2a664c1

caouecs closed this as completed Jul 13, 2020

caouecs added a commit that referenced this issue Jul 14, 2020

fix: #1269 with json files

fe2872f

overtrue mentioned this issue Sep 7, 2020

Update README.md overtrue/laravel-lang#58

Closed

andrey-helldar mentioned this issue Nov 25, 2020

[sr, uz, me] Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) #1453

Merged

xiaomlove mentioned this issue Feb 18, 2021

语言文件夹命名建议使用下划线遵循 ISO-15879 标准 z-song/laravel-admin#5238

Closed

aczyt mentioned this issue Jan 9, 2022

Can't seem to get trans to work xiCO2k/laravel-vue-i18n#2

Closed

nvasic88 mentioned this issue Apr 17, 2023

Adding Montenegrin language support. Biologer/Biologer#101

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISO 15897 format of country specific locales #1269

ISO 15897 format of country specific locales #1269

bjoerne2 commented Jun 24, 2020

caouecs commented Jun 25, 2020

bjoerne2 commented Jul 3, 2020

caouecs commented Jul 8, 2020

caouecs commented Jul 11, 2020

andrey-helldar commented Jul 11, 2020 •

edited

Loading

caouecs commented Jul 13, 2020

milose commented Nov 24, 2020

andrey-helldar commented Nov 24, 2020

caouecs commented Nov 25, 2020

andrey-helldar commented Nov 25, 2020

LukaLatkovic commented Nov 26, 2020 •

edited

Loading

LukaLatkovic commented Nov 26, 2020 •

edited

Loading

milose commented Nov 26, 2020

andrey-helldar commented Nov 27, 2020 •

edited

Loading

milose commented Nov 27, 2020 •

edited

Loading

andrey-helldar commented Nov 27, 2020 •

edited

Loading

milose commented Nov 30, 2020

andrey-helldar commented Dec 4, 2020

caouecs commented Dec 4, 2020

ISO 15897 format of country specific locales #1269

ISO 15897 format of country specific locales #1269

Comments

bjoerne2 commented Jun 24, 2020

caouecs commented Jun 25, 2020

bjoerne2 commented Jul 3, 2020

caouecs commented Jul 8, 2020

caouecs commented Jul 11, 2020

andrey-helldar commented Jul 11, 2020 • edited Loading

caouecs commented Jul 13, 2020

milose commented Nov 24, 2020

andrey-helldar commented Nov 24, 2020

caouecs commented Nov 25, 2020

andrey-helldar commented Nov 25, 2020

LukaLatkovic commented Nov 26, 2020 • edited Loading

LukaLatkovic commented Nov 26, 2020 • edited Loading

milose commented Nov 26, 2020

andrey-helldar commented Nov 27, 2020 • edited Loading

milose commented Nov 27, 2020 • edited Loading

andrey-helldar commented Nov 27, 2020 • edited Loading

milose commented Nov 30, 2020

andrey-helldar commented Dec 4, 2020

caouecs commented Dec 4, 2020

andrey-helldar commented Jul 11, 2020 •

edited

Loading

LukaLatkovic commented Nov 26, 2020 •

edited

Loading

LukaLatkovic commented Nov 26, 2020 •

edited

Loading

andrey-helldar commented Nov 27, 2020 •

edited

Loading

milose commented Nov 27, 2020 •

edited

Loading

andrey-helldar commented Nov 27, 2020 •

edited

Loading