Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sr, uz, me] Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) #1453

Merged
merged 3 commits into from
Nov 30, 2020
Merged

[sr, uz, me] Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) #1453

merged 3 commits into from
Nov 30, 2020

Conversation

andrey-helldar
Copy link
Member

Based on #1269 (comment)

@andrey-helldar andrey-helldar mentioned this pull request Nov 25, 2020
Closed
@andrey-helldar andrey-helldar changed the title Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn Nov 25, 2020
@andrey-helldar andrey-helldar changed the title Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) Nov 25, 2020
@andrey-helldar andrey-helldar changed the title Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) [sr, uz] Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) Nov 25, 2020
@caouecs
Copy link
Member

caouecs commented Nov 26, 2020

I'm ok but it's a big change ( new version needed )

LukaLatkovic
LukaLatkovic suggested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@LukaLatkovic LukaLatkovic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i said in #1269 comment

@andrey-helldar andrey-helldar changed the title [sr, uz] Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) [sr, uz, me] Rename *_Cyrillic to *_Cyrl and *_Latin to *_Latn (php Intl) Nov 26, 2020
LukaLatkovic
LukaLatkovic approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@LukaLatkovic LukaLatkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

@andrey-helldar
Copy link
Member Author

@caouecs, ping

@caouecs
Copy link
Member

caouecs commented Nov 27, 2020

version 8 ? :)

@andrey-helldar
Copy link
Member Author

I think yes) Change is necessary and big.

@andrey-helldar andrey-helldar mentioned this pull request Nov 27, 2020
Merged
@caouecs caouecs merged commit 6fe4406 into Laravel-Lang:master Nov 30, 2020
@caouecs
Copy link
Member

caouecs commented Nov 30, 2020

I prepare v8

@andrey-helldar
Copy link
Member Author

andrey-helldar commented Dec 1, 2020 •
edited
Loading

@caouecs, Merci! J'ai publié ma version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaLatkovic LukaLatkovic LukaLatkovic approved these changes

@caouecs caouecs Awaiting requested review from caouecs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrey-helldar @caouecs @LukaLatkovic