Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Remove ffmpeg_kit_flutter from the package #156

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Conversation

LeGoffMael
Copy link
Owner

This PR is part of #147.
Will fix duplicate library issues like #37, #129, #153.

@LeGoffMael LeGoffMael added the enhancement New feature or request label Jun 23, 2023
@LeGoffMael
Copy link
Owner Author

@maRci002 Would this be ok to merge this PR before yours (#147) ?
I would like to release the 3.0.0 without the FFmpeg and with other fixes.

Once the video_thumbnail is ready for web, we could release it as 4.0.0.
(The whole structure of files of the project is actually changed, sorry if it caused a lot of changes on your side)

@maRci002
Copy link

maRci002 commented Jun 23, 2023

@maRci002 Would this be ok to merge this PR before yours (#147) ?

Yes, you can merge this PR. After that, I'm going to update PR #147.

Once the video_thumbnail is ready for web, we could release it as 4.0.0.

I don't think a major version change is necessary. This is because it will only update the example code, modify some underlying painter functionality, and slightly affect the FFmpegVideoEditorConfig and its subclasses.
You are right VideoEditorController will use XFile

- removed VideoExportPreset
- removed customInstruction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants