-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] remove ffmpeg_kit dependency and add web implementation #147
base: master
Are you sure you want to change the base?
[Refactor] remove ffmpeg_kit dependency and add web implementation #147
Conversation
Thank you a lot for your work this is really great ! However the web support cannot seems to be published without the video_thumbnail package being updated first. |
I have a question about why |
Because you would have to import dart:io which won't work on web. The |
On the web, when you want to play a
|
Hello |
What's the status for web? Is it done? Can we use the web version of video_editor? Thank you in advance. |
video_thumbnail:
git:
url: https://github.com/maRci002/video_thumbnail.git
ref: feat-web_implementation
path: video_thumbnail
video_editor:
git:
url: git@github.com:maRci002/video_editor.git
ref: feature/separate-video-export
The primary focus of this PR was on two aspects: removing the ffmpeg_kit dependency and adding a web implementation. PR #156 had already removed the ffmpeg_kit dependency and introduced some helper functionality to generate ffmpeg commands. My changes are quite similar; however, they have resulted in some conflicts. Therefore, my first step is to make this PR compatible with the current master branch. The web implementation will introduce some breaking changes, such as the use of XFile instead of File, unless the VideoEditorController.networkUrl constructor is used. XFile is beneficial as it holds important information like the mimeType and allows easy access to bytes, which is useful for working with the web ffmpeg library.
It appears that the video_thumbnail package has been abandoned. I am considering forking it to enhance its capabilities, such as supporting web or providing support for a Stream of thumbnails. This approach would be more efficient, as the underlying generator (such as AVAssetImageGenerator or MediaMetadataRetriever) wouldn't need to be opened and closed repeatedly but could remain open as needed for each frame. |
Hi guy's, do we have any new about this package for web ? Thank you in advance |
closes #146
This PR contains the following:
ffmpeg_kit
package.FFmpegConfig
to improve video and cover export functionality.ffmpeg_kit
orffmpeg_wasm
, depending on the platform.video_thumbnail
version to 0.6.0.Breaking changes
File
withXFile
inVideoEditorController.file
.VideoEditorController.getMetaData
.VideoEditorController.exportVideo
.VideoEditorController.extractCover
.Still need:
git
andlocal
path frompubspec.yaml
, this needs the Pull Requests to be merged.executeFFmpegWeb
andexecuteFFmpegIO
methods in the example.CropScreen
is closed theVideoPlayer
is blackVideoPlayer
at the same time:CropGridViewer.preview
/CropGridViewer.edit
VideoPlayer
key must change as soon as we are done croppingcropStyle: const CropGridStyle(background: Colors.transparent),
is needed on the web. It seems thatPath.combine
breaks on the web.Path
'sfillType
toPathFillType.evenOdd
Please refer to the redleafsofts/flutter_ffmpeg_wasm#1
README
for instructions on how to runffmpeg_wasm
on the web.This is what it looks like on the web (using HTML renderer):
video_editor_on_the_web.mp4