Only Nano S+ is currently supported #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NanoX is not supported (see issue mobilecoinofficial#27), so it is useless to build it.
Moreover, when building the fw for Nano X in ledger-app-builder, through
cargo ledger build nanox
and using NanoX custom target file (see target NanoX defined here) which is available in the container, there is an issue withheapless
crate build:This issue may be due to https://doc.rust-lang.org/std/sync/atomic/index.html#portability.
The issue is not seen when building with the target file provided in the repo (i.e.
fw/nanox.json
) withcargo build --targe ./nanox.json --release
When comparing both target files (Ledger vs Mobilecoin), there are significant differences, for instance
llvm-target
.As nowadays NanoX is not supported, I propose to build only for Nano S+ device.