Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove solid-secondary button as it's deprecated #450

Closed
elenagarrone opened this issue Jul 5, 2021 · 3 comments · Fixed by #456
Closed

Remove solid-secondary button as it's deprecated #450

elenagarrone opened this issue Jul 5, 2021 · 3 comments · Fixed by #456
Labels
breaking change An issue that when resolved will be a breaking change good first issue Good for newcomers released on @next released

Comments

@elenagarrone
Copy link
Contributor

The solid-secondary button needs removing as the designers said we should only be using the blue one.

We could avoid a breaking change by setting it to be blue initially as the solid-primary.
@elenagarrone elenagarrone added good first issue Good for newcomers breaking change An issue that when resolved will be a breaking change labels Jul 5, 2021
@Patil2099
Copy link
Contributor

I would love to pick this up.

@Patil2099 Patil2099 mentioned this issue Jul 5, 2021
Closed
owensgit pushed a commit to owensgit/canopy that referenced this issue Jul 9, 2021
@Patil2099 @owensgit
feat(buttons): remove solid-secondary button
3c6ed9a 
BREAKING CHANGE: removed the `solid-secondary` button variant. Use the `solid-primary` or any other button variant instead.

fix: Legal-and-General#450
@owensgit owensgit mentioned this issue Jul 9, 2021
Merged
6 tasks
andy-polhill pushed a commit that referenced this issue Jul 12, 2021
@Patil2099 @andy-polhill
feat(buttons): remove solid-secondary button
1a4c21d 
BREAKING CHANGE: removed the `solid-secondary` button variant. Use the `solid-primary` or any other button variant instead.

fix: #450
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

elenagarrone pushed a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@Patil2099 @elenagarrone
feat(buttons): remove solid-secondary button
d90d5cf 
BREAKING CHANGE: removed the `solid-secondary` button variant. Use the `solid-primary` or any other button variant instead.

fix: Legal-and-General#450
elenagarrone pushed a commit to elenagarrone/canopy that referenced this issue Feb 3, 2022
@Patil2099 @elenagarrone
feat(buttons): remove solid-secondary button
8a4fc10 
BREAKING CHANGE: removed the `solid-secondary` button variant. Use the `solid-primary` or any other button variant instead.

fix: Legal-and-General#450
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change An issue that when resolved will be a breaking change good first issue Good for newcomers released on @next released
Projects
None yet
Milestone
No milestone
2 participants
@elenagarrone @Patil2099