Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buttons): remove solid-secondary button #456

Merged
merged 1 commit into from
Jul 12, 2021
Merged

feat(buttons): remove solid-secondary button #456

merged 1 commit into from
Jul 12, 2021

Conversation

owensgit
Copy link
Contributor

@owensgit owensgit commented Jul 9, 2021 •
edited by elenagarrone
Loading

Description

This recreates the original PR by @Patil2099 (#451), to remove the solid-secondary button variant.

BREAKING CHANGE: removed the solid-secondary button variant. Use the solid-primary or any other button variant instead.

fix: #450

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage
  • I have added the functionality to the test app
  • I have provided a story in storybook to document the changes
  • I have provided documentation in the notes section of the story
  • I have added any new public feature modules to public-api.ts

@Patil2099 @owensgit
feat(buttons): remove solid-secondary button
3c6ed9a 
BREAKING CHANGE: removed the `solid-secondary` button variant. Use the `solid-primary` or any other button variant instead.

fix: Legal-and-General#450
@owensgit owensgit requested a review from a team as a code owner July 9, 2021 08:58
@owensgit owensgit mentioned this pull request Jul 9, 2021
Closed
@owensgit owensgit changed the base branch from master to next July 9, 2021 09:01
@owensgit owensgit mentioned this pull request Jul 9, 2021
Closed
@owensgit
Copy link
Contributor Author

owensgit commented Jul 9, 2021

Linking in this issue to keep track of upcoming breaking changes: #315

Hopkinsa
Hopkinsa approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Hopkinsa Hopkinsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change may need to be mentioned to anyone using Canopy, as the designs we work from still show a green secondary button.

@andy-polhill andy-polhill merged commit 1a4c21d into Legal-and-General:next Jul 12, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@owensgit owensgit deleted the Patil2099/master branch June 27, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hopkinsa Hopkinsa Hopkinsa approved these changes

@elenagarrone elenagarrone elenagarrone approved these changes

@andy-polhill andy-polhill andy-polhill approved these changes

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove solid-secondary button as it's deprecated
5 participants
@owensgit @andy-polhill @elenagarrone @Hopkinsa @Patil2099