Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Optimize CI config #2802

Merged
merged 4 commits into from
Apr 13, 2023
Merged

Fix & Optimize CI config #2802

merged 4 commits into from
Apr 13, 2023

Conversation

6543
Copy link
Contributor

@6543 6543 commented Apr 13, 2023

No description provided.

@6543 6543 requested review from Nutomic and dessalines as code owners April 13, 2023 16:45
.woodpecker.yml Show resolved Hide resolved
.woodpecker.yml Show resolved Hide resolved
.woodpecker.yml Show resolved Hide resolved
@6543
Copy link
Contributor Author

6543 commented Apr 13, 2023

PS: I'll have a look into multiarch build for your docker ... so it does not matter at witch arch the agent is running in order to generate arm/x86 images

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these! I'll apply that variable technique to the other woodpecker projects we have set up.

.woodpecker.yml Show resolved Hide resolved
.woodpecker.yml Show resolved Hide resolved
@6543
Copy link
Contributor Author

6543 commented Apr 13, 2023

ok got cross compile working -> #2804

so now it doesn't matter if you run the docker-buildx step on x86 or arm64 :)

tldr: one step to compile for both arch


I'll keep mentioned pull as draft until this here got merged

@6543
Copy link
Contributor Author

6543 commented Apr 13, 2023

@dessalines CI passed

@Nutomic Nutomic merged commit e7a2080 into LemmyNet:main Apr 13, 2023
@6543 6543 deleted the optimize_ci branch April 13, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants