Use official rust image and clean up Dockerfiles #2804
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
6543
force-pushed
the
use_official_rust_images_for-arm-support
branch
from
f7f6a23 to
ef4c80f
Compare
|
next test: https://woodpecker.join-lemmy.org/LemmyNet/lemmy/pipeline/119/3 will push a revert commit to the last one to restore the pipeline to what it should alter too ... |
This comment was marked as outdated.
This comment was marked as outdated.
manifest not needed, its handled by buildx plugin
6543
force-pushed
the
use_official_rust_images_for-arm-support
branch
from
b245eb2 to
1f5f3a6
Compare
6543
force-pushed
the
use_official_rust_images_for-arm-support
branch
from
1f5f3a6 to
acc687f
Compare
6543
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
6543
changed the title
6543
force-pushed
the
use_official_rust_images_for-arm-support
branch
from
cf3dd88 to
8bc035a
Compare
|
move cross compile into #2806 as it's blocked by dep "ring" :/ |
|
@dessalines @Nutomic ready to review |
| COPY --from=builder /app/lemmy_server /app/lemmy | ||
|
|
||
| EXPOSE 8536 | ||
| CMD ["/app/lemmy"] |
There was a problem hiding this comment.
Should probably remove this file as cross-compile isnt working. And based on the age of the issue it wont get fixed anytime soon :(
There was a problem hiding this comment.
This pull does not address cross compilation!
Its moved in a extra pull
There was a problem hiding this comment.
Looks like this was added to the main branch anyway.
There was a problem hiding this comment.
the multiarch docker image is just ment to be build with buildx ... and the cross-compiline is just an optional feature ... for now I would recomend to just use it as single source of truth and have different agents that target this dockerfile
the old Dockerfile is just for normal devs who wana build the image but dont have buildx installed
There was a problem hiding this comment.
In that case I would prefer to remove the old dockerfile, and list buildx as a requirements. cc @dessalines
There was a problem hiding this comment.
Ok fine with that ... I have a look in altering the docs/readme
There was a problem hiding this comment.
Yep, I'm def fine with removing the old Dockerfile
There was a problem hiding this comment.
Well the "old" is the same as the new one ... just without some fancy if statements and args on FROM 😆. so you can make the multiarch to a normal one again at any time
|
Deleted :) |
Note: Due to briansmith/ring#1414, we cannot cross-compile during the build step. So we either emulate the build step but that will increase build time significant, or we still have to use dedicated agents as it is proposed now