Fix strict torch_xla availability check #16476

awaelchli · 2023-01-23T11:09:56Z

What does this PR do?

Following the release of lightning-utilities 0.6.0.
I verified in Google Colab that the changes on this branch fix the issue:

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @JackCaoG @steventk-g @Liyang90

github-actions · 2023-01-23T15:36:54Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/accelerators/tpu.py, requirements/pytorch/base.txt.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/fabric/base.txt, src/lightning_fabric/accelerators/tpu.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	success	✅

These checks are required after the changes to requirements/pytorch/base.txt.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/accelerators/tpu.py, requirements/pytorch/base.txt.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/accelerators/tpu.py, requirements/pytorch/base.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.10, 11.3.1)	success	✅
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.7.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.10)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.10, 11.3.1)	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.7.1)	success	✅
build-xla (3.7, 1.12)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/fabric/base.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/accelerators/tpu.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning_fabric/accelerators/tpu.py.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, app, 3.8, latest)	success	✅
app-pytest (macOS-11, app, 3.8, oldest)	success	✅
app-pytest (macOS-11, lightning, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, app, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.8, oldest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅

These checks are required after the changes to requirements/app/base.txt.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (macOS-11, app, 3.9, oldest)	success	✅
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅
app-examples (windows-2022, app, 3.9, oldest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅

These checks are required after the changes to requirements/app/base.txt.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to requirements/app/base.txt.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to requirements/app/base.txt.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/app/base.txt, requirements/fabric/base.txt, requirements/pytorch/base.txt, src/lightning_fabric/accelerators/tpu.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning_fabric/accelerators/tpu.py, requirements/app/base.txt, requirements/fabric/base.txt, requirements/pytorch/base.txt.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning_fabric/CHANGELOG.md, src/pytorch_lightning/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

…x/xla-available

awaelchli · 2023-01-23T15:45:06Z

It's still installing lightning-utilities=0.5.0 😡

requirements/fabric/base.txt

carmocca · 2023-01-24T12:44:33Z

There's now a dependency issue with packaging. I don't know why and how we use this package so maybe @Borda can help here

requirements/app/base.txt

requirements/pytorch/base.txt

requirements/fabric/base.txt

Borda · 2023-01-24T18:08:43Z

There's now a dependency issue with packaging. I don't know why and how we use this package so maybe @Borda can help here

Updating as this was probably forgotten CI bump, we do not have packaging with strict so there is no reason to have this freeze

UPDATE: it came from Lightning-AI/utilities#76 so we can lower it back if we really need

requirements/fabric/base.txt

requirements/pytorch/base.txt

requirements/fabric/base.txt

requirements/pytorch/base.txt

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit 961fa6a)

fix

32babb1

awaelchli added bug Something isn't working accelerator: tpu Tensor Processing Unit labels Jan 23, 2023

awaelchli added this to the v1.9.x milestone Jan 23, 2023

awaelchli self-assigned this Jan 23, 2023

carmocca approved these changes Jan 23, 2023

View reviewed changes

awaelchli marked this pull request as ready for review January 23, 2023 15:36

awaelchli requested a review from justusschock as a code owner January 23, 2023 15:36

Merge branch 'master' into bugfix/xla-available

d0fb425

awaelchli marked this pull request as draft January 23, 2023 15:36

awaelchli added 3 commits January 23, 2023 16:37

changelog

1e8a7be

Merge remote-tracking branch 'origin/bugfix/xla-available' into bugfi…

a342e1c

…x/xla-available

bump version

24a204f

awaelchli marked this pull request as ready for review January 23, 2023 19:06

awaelchli requested review from williamFalcon, lantiga, Borda and tchaton as code owners January 23, 2023 19:06

Merge branch 'master' into bugfix/xla-available

d42cc5e

awaelchli force-pushed the bugfix/xla-available branch from 1b3eb46 to d42cc5e Compare January 23, 2023 22:09

carmocca reviewed Jan 24, 2023

View reviewed changes

requirements/fabric/base.txt Outdated Show resolved Hide resolved

bump min version!

727a39d

Borda approved these changes Jan 24, 2023

View reviewed changes

requirements/app/base.txt Show resolved Hide resolved

mergify bot added the ready PRs ready to be merged label Jan 24, 2023

Borda reviewed Jan 24, 2023

View reviewed changes

requirements/pytorch/base.txt Outdated Show resolved Hide resolved

Borda reviewed Jan 24, 2023

View reviewed changes

requirements/fabric/base.txt Outdated Show resolved Hide resolved

Apply suggestions from code review

6a6d505

Borda reviewed Jan 24, 2023

View reviewed changes

requirements/fabric/base.txt Outdated Show resolved Hide resolved

Borda reviewed Jan 24, 2023

View reviewed changes

requirements/pytorch/base.txt Outdated Show resolved Hide resolved

Apply suggestions from code review

fb0dc8b

Borda mentioned this pull request Jan 24, 2023

lower min packaging version Lightning-AI/utilities#91

Merged

4 tasks

Borda and others added 3 commits January 25, 2023 01:48

versions

075cd77

Merge branch 'master' into bugfix/xla-available

cb39336

Merge branch 'master' into bugfix/xla-available

d490d2e

github-actions bot added app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jan 25, 2023

Merge branch 'master' into bugfix/xla-available

77880c7

Borda reviewed Jan 25, 2023

View reviewed changes

requirements/fabric/base.txt Outdated Show resolved Hide resolved

Borda reviewed Jan 25, 2023

View reviewed changes

requirements/pytorch/base.txt Outdated Show resolved Hide resolved

Borda added 2 commits January 25, 2023 15:17

Apply suggestions from code review

083ae87

Merge branch 'master' into bugfix/xla-available

71665cc

Borda enabled auto-merge (squash) January 25, 2023 14:17

awaelchli added 2 commits January 25, 2023 18:53

suggestion

759cd6f

pytorch too

90063bc

Borda merged commit 961fa6a into master Jan 25, 2023

Borda deleted the bugfix/xla-available branch January 25, 2023 18:52

Borda mentioned this pull request Jan 26, 2023

relax packaging versions #16508

Merged

12 tasks

Borda pushed a commit that referenced this pull request Feb 9, 2023

Fix strict torch_xla availability check (#16476)

4532ad6

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit 961fa6a)

lantiga pushed a commit that referenced this pull request Feb 10, 2023

Fix strict torch_xla availability check (#16476)

99236fd

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit 961fa6a)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix strict torch_xla availability check #16476

Fix strict torch_xla availability check #16476

awaelchli commented Jan 23, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 23, 2023 •

edited

Loading

awaelchli commented Jan 23, 2023 •

edited

Loading

carmocca commented Jan 24, 2023

Borda commented Jan 24, 2023 •

edited

Loading

Fix strict torch_xla availability check #16476

Fix strict torch_xla availability check #16476

Conversation

awaelchli commented Jan 23, 2023 • edited by github-actions bot Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

github-actions bot commented Jan 23, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

awaelchli commented Jan 23, 2023 • edited Loading

carmocca commented Jan 24, 2023

Borda commented Jan 24, 2023 • edited Loading

awaelchli commented Jan 23, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 23, 2023 •

edited

Loading

awaelchli commented Jan 23, 2023 •

edited

Loading

Borda commented Jan 24, 2023 •

edited

Loading