Fix & extend pkg install check #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
added
bug
Borda
force-pushed
the
ci/install-pkg
branch
from
03649e4
to
ea47562
Compare
akihironitta
approved these changes
Dec 19, 2022
Borda
force-pushed
the
ci/install-pkg
branch
from
116c8d5
to
775a99f
Compare
Borda
force-pushed
the
ci/install-pkg
branch
2 times, most recently
from
e235f27
to
18201d2
Compare
Borda
force-pushed
the
ci/install-pkg
branch
from
18201d2
to
dc1b8f3
Compare
awaelchli
approved these changes
Dec 19, 2022
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
turned out that this package may have have missing dependency
packagingPR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃