Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min Pytorch to 1.10 #2145

Merged
merged 26 commits into from
Oct 11, 2023
Merged

Update min Pytorch to 1.10 #2145

merged 26 commits into from
Oct 11, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 5, 2023

What does this PR do?

Updates minimum pytorch from 1.8 to 1.10.
Version 1.10 was released on Oct 21, 2021, meaning that we will still be supporting a version close to 2 years old with this update. For reference, version 1.8 was released on Mar 4, 2021.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2145.org.readthedocs.build/en/2145/

@Borda Borda enabled auto-merge (squash) October 6, 2023 14:02
@Borda
Copy link
Member

Borda commented Oct 6, 2023

let's first add 2.1 in #2142

@mergify mergify bot added the has conflicts label Oct 8, 2023
@mergify mergify bot removed the has conflicts label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2145 (2ec1959) into master (5c6b23c) will decrease coverage by 0%.
Report is 2 commits behind head on master.
The diff coverage is 71%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2145   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         293     293           
  Lines       16430   16410   -20     
======================================
- Hits        14286   14256   -30     
- Misses       2144    2154   +10     

@mergify mergify bot added the ready label Oct 9, 2023
@mergify mergify bot removed the has conflicts label Oct 11, 2023
@Borda Borda disabled auto-merge October 11, 2023 09:30
@Borda Borda merged commit 09bd064 into master Oct 11, 2023
65 of 71 checks passed
@Borda Borda deleted the update_min_pytorch branch October 11, 2023 09:30
@mergify mergify bot removed the ready label Oct 11, 2023
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Oct 14, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants