Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releasing minor 1.2.1 [rebase & merge] #2249

Merged
merged 81 commits into from
Dec 1, 2023
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 30, 2023

What does this PR do?

releasing bug fix

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2249.org.readthedocs.build/en/2249/

Borda and others added 30 commits November 30, 2023 22:45
(cherry picked from commit eef32ce)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit acec075)
…nts (#2109)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 0d78c77)
…,<3.0.0 in /requirements (#2110)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit a427379)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit ff68802)
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Luca Di Liello <luca.diliello@unitn.it>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit 64f17f0)
* calcualte

* insesitivity

* AVAILABEL

* specifity

* indeces

* Avarage

* _irs_mis_sz

* symetrical

* _irs_mis_sz_fn

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 9aecaf4)
(cherry picked from commit 1ddacab)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit e5b1893)
(cherry picked from commit e55fd0c)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 94f25d5)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 4dd2b93)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 39ba91a)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 886c09b)
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit bd8e556)
…duction (#2119)

Clarify input shape expectation in classification for `samplewise` reduction

(cherry picked from commit 2c18063)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 44984f5)
…=1.1.1,<1.4 in /requirements (#2132)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 64e2d19)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
(cherry picked from commit 2387f2a)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit f925113)
* improve stability

* changelog

(cherry picked from commit 1d10277)
(cherry picked from commit 6d902a6)
(cherry picked from commit 89ca22b)
…#2158)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit bfb40ae)
…>=2021.9.24,<=2023.10.3 in /requirements (#2159)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit a674826)
Borda and others added 16 commits November 30, 2023 23:06
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
(cherry picked from commit 9652899)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>

(cherry picked from commit 1b16341)
* Use meshgrid for deterministic bincount

* Update src/torchmetrics/utilities/data.py

Use arange instead of meashgrid

* Update data.py

Update _bincount doc

* chlog

* size

* Update CHANGELOG.md

update changelog

* Update data.py

update comment

* improve text

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

(cherry picked from commit 8ef2a89)
(cherry picked from commit bb024f6)
Bumps [mypy](https://github.com/python/mypy) from 1.7.0 to 1.7.1.
- [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md)
- [Commits](python/mypy@v1.7.0...v1.7.1)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 8acfaec)
…ents (#2245)

build(deps): bump pytest-rerunfailures in /requirements

Bumps [pytest-rerunfailures](https://github.com/pytest-dev/pytest-rerunfailures) from 12.0 to 13.0.
- [Changelog](https://github.com/pytest-dev/pytest-rerunfailures/blob/master/CHANGES.rst)
- [Commits](pytest-dev/pytest-rerunfailures@12.0...13.0)

---
updated-dependencies:
- dependency-name: pytest-rerunfailures
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit cb1666a)
…>=2.0.0,<2.2 in /requirements (#2247)

* build(deps): update scienceplots requirement in /requirements

Updates the requirements on [scienceplots](https://github.com/garrettj403/SciencePlots) to permit the latest version.
- [Release notes](https://github.com/garrettj403/SciencePlots/releases)
- [Changelog](https://github.com/garrettj403/SciencePlots/blob/master/CHANGES.md)
- [Commits](garrettj403/SciencePlots@2.0.0...2.1.1)

---
updated-dependencies:
- dependency-name: scienceplots
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Apply suggestions from code review

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 0cb4c79)
* lazy multimodal

* lazy image

* fix import logic

* fix import logic

* revert

* fixes

* fixes

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 46dfa42)
…8.0 to >=0.8.0,<0.11.0 in /requirements (#2246)

build(deps): update lightning-utilities requirement in /requirements

Updates the requirements on [lightning-utilities](https://github.com/Lightning-AI/utilities) to permit the latest version.
- [Release notes](https://github.com/Lightning-AI/utilities/releases)
- [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md)
- [Commits](Lightning-AI/utilities@v0.9.0...v0.10.0)

---
updated-dependencies:
- dependency-name: lightning-utilities
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit c4893a1)
…e provided for `pycocotools` backend (#2219)

(cherry picked from commit 56c0fdf)
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 58ffb01)
@Borda Borda changed the title releasing minor 1.2.1 [wip] releasing minor 1.2.1 [rebase & merge] Nov 30, 2023
@Borda
Copy link
Member Author

Borda commented Nov 30, 2023

@SkafteNicki thoughts on this exception with torch 1.8?

UNEXPECTED EXCEPTION: AttributeError("module 'torch' has no attribute 'frombuffer'")
Traceback (most recent call last):
  File "/usr/lib/python3.8/doctest.py", line 1336, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest torchmetrics.text.bert.BERTScore.plot[5]>", line 1, in <module>
  File "/__w/3/s/src/torchmetrics/text/bert.py", line 309, in plot
    val = self.compute()  # type: ignore
  File "/__w/3/s/src/torchmetrics/metric.py", line 610, in wrapped_func
    value = _squeeze_if_scalar(compute(*args, **kwargs))
  File "/__w/3/s/src/torchmetrics/text/bert.py", line 241, in compute
    return bert_score(
  File "/__w/3/s/src/torchmetrics/functional/text/bert.py", line 360, in bert_score
    model = AutoModel.from_pretrained(model_name_or_path or _DEFAULT_MODEL)
  File "/usr/local/lib/python3.8/dist-packages/transformers/models/auto/auto_factory.py", line 566, in from_pretrained
    return model_class.from_pretrained(
  File "/usr/local/lib/python3.8/dist-packages/transformers/modeling_utils.py", line 3170, in from_pretrained
    state_dict = load_state_dict(resolved_archive_file)
  File "/usr/local/lib/python3.8/dist-packages/transformers/modeling_utils.py", line 474, in load_state_dict
    return safe_load_file(checkpoint_file)
  File "/usr/local/lib/python3.8/dist-packages/safetensors/torch.py", line 310, in load_file
    result[k] = f.get_tensor(k)
AttributeError: module 'torch' has no attribute 'frombuffer'
/__w/3/s/src/torchmetrics/text/bert.py:289: UnexpectedException

@Borda Borda force-pushed the releasing/1.2.1 branch 2 times, most recently from 8bad6d8 to 959cefd Compare November 30, 2023 22:40
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #2249 (ffb48af) into release/stable (0d7d6c7) will decrease coverage by 0%.
The diff coverage is 80%.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/stable   #2249   +/-   ##
==============================================
- Coverage              87%     87%   -0%     
==============================================
  Files                 293     293           
  Lines               16299   16344   +45     
==============================================
+ Hits                14177   14195   +18     
- Misses               2122    2149   +27     

@SkafteNicki
Copy link
Member

@Borda we updated to minimum Pytorch 1.10 in this PR: #2145, so you are seeing problems due to some of the checks that was removed in that PR (there should probably have been an entry in the changelog about this change)

@Borda
Copy link
Member Author

Borda commented Dec 1, 2023

we updated to minimum Pytorch 1.10 in this PR: #2145, so you are seeing problems due to some of the checks that was removed in that PR (there should probably have been an entry in the changelog about this change)

yes I know, but we normally do not change nim requirement between bug-fix releases, so I was trying to find what are the root and a patch on the CI side is #2250

@mergify mergify bot added the ready label Dec 1, 2023
@Borda Borda merged commit 3514d71 into release/stable Dec 1, 2023
66 checks passed
@Borda Borda deleted the releasing/1.2.1 branch December 1, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants