-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hparams.encoder forgotten rename in CPCv2 #773
Fix hparams.encoder forgotten rename in CPCv2 #773
Conversation
Skip reason is no longer valid. In the meantime another errors were introduced, a workaround is for 2e903c3
Co-authored-by: praecipue <43908213+praecipue@users.noreply.github.com>
@praecipue mind check the failing GPU test? just restarted the job to see if it was related to your change... 🐰 |
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
For some reason spawning DDP process was causing failure. I think it is not related to my change. Is DDP spawn tested anywhere on azure? |
* Re-enable testing CPCv2 * Fix hparams forgotten rename in CPCv2 module Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 PyTorchLightning#264, but not in forward method. That leads to different errors depending on used encoder module.
CPC module test skip reason is misleading. In the meantime another errors were introduced, a workaround is for 2e903c3
What does this PR do?
Re-enable testing CPCv2
Workaround bug introduced by 2e903c3
The error is misleading, the cause is overlooked hparam rename fixed in the following commit
Fixes problem similar to #680 (#679 issue) and re-enables test
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃