Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hparams.encoder forgotten rename in CPCv2 #773

Merged
merged 10 commits into from
Nov 26, 2021
Merged

Fix hparams.encoder forgotten rename in CPCv2 #773

merged 10 commits into from
Nov 26, 2021

Commits on Nov 18, 2021

  1. Re-enable testing CPCv2 

    Skip reason is no longer valid. In the meantime another errors were introduced, a workaround is for 2e903c3
    @praecipue
    praecipue authored Nov 18, 2021
    Configuration menu
    Copy the full SHA
    14f3361 View commit details
    Browse the repository at this point in the history

  2. Break too long comment line

    @praecipue
    praecipue authored Nov 18, 2021
    Configuration menu
    Copy the full SHA
    b20bba8 View commit details
    Browse the repository at this point in the history

  3. Fix hparams forgotten rename in CPCv2 module 

    self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 PyTorchLightning#264
Rename overlooked occurrence as in 2163626 PyTorchLightning#680
    @praecipue
    praecipue authored Nov 18, 2021
    Configuration menu
    Copy the full SHA
    62fbdc9 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Apply suggestions from code review 

    Co-authored-by: praecipue <43908213+praecipue@users.noreply.github.com>
    @Borda @praecipue
    Borda and praecipue authored Nov 26, 2021
    Configuration menu
    Copy the full SHA
    4904c2b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/cpc-hparams-encoder

    @mergify
    mergify[bot] authored Nov 26, 2021
    Configuration menu
    Copy the full SHA
    6af6d57 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into bugfix/cpc-hparams-encoder

    @mergify
    mergify[bot] authored Nov 26, 2021
    Configuration menu
    Copy the full SHA
    a77a624 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into bugfix/cpc-hparams-encoder

    @mergify
    mergify[bot] authored Nov 26, 2021
    Configuration menu
    Copy the full SHA
    a1edb69 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into bugfix/cpc-hparams-encoder

    @mergify
    mergify[bot] authored Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b374ab4 View commit details
    Browse the repository at this point in the history

  6. Avoid ddp_spawn in azure pipeline testing 

    use at most 1 GPU
    @praecipue
    praecipue authored Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2b415bc View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b2d4c2d View commit details
    Browse the repository at this point in the history