Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a setHeight method to the player ref to resize it #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kloadut
Copy link

@Kloadut Kloadut commented Nov 10, 2021

I wanted to resize the player on the fly, for example to support vertical videos like https://youtu.be/GeYK9JdPVMw.

I added a new method to the YoutubePlayer ref in order to do that. Let me know if that's a feature you'd be interested in and if there's anything you'd like me to change.

Cheers!

@LonelyCpp
Copy link
Owner

Hey, terribly sorry for the late reply.

This is a good feature to have, but would be better to directly set the height prop on the component.

We'll have to make this #13 (comment) into a toggleable prop. after enabling this, users can simply change the height and width prop to get the desired effect

@LonelyCpp
Copy link
Owner

let me know if you wanna work on this, else I'll take it up

@Kloadut
Copy link
Author

Kloadut commented Dec 16, 2021

Hola! No worries :)

Work on it if you find time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants