-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add a missing check for 'inject-field' diagnostics #2747
Conversation
Glad that you finally find a proper way to fix it 😄 And as @C3pa mentioned here, I tested your fix on a few similar issues and all of them are cleared now! One stone three birds! 🎉
In your PR description, instead of
Only then can properly link the pull request to those issues, and leverage the github's close issue on PR merge function. It requires the keywords (in your case is the word |
c9ee150
to
8c1e121
Compare
@tomlau10 Thanks for mentioning all the fixed issues! Helps a bunch with organization! I linked them to this PR 🙂. |
Thank you! |
fix related to #2746