-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Draft decision-making file #539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 23 23
Lines 1913 1913
=======================================
Hits 1722 1722
Misses 191 191 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I (kinda) love being at the top of the list of maintainers (and I am really hoping to live up to that position...in time) I truly dislike that it is just due to the tyranny of the alphabet rather than effort. Should it be first sorted by time, then alphabet? I'm not strongly opposed mind you, I just think it unfairly favors me (my name is early here, on posters, on github, etc)
In a more general comment, I like seeing this all together - the governance discussion was a bit confusing to me, but this clarifies it.
according to Rule 4. | ||
1. Any Maintainer can Review a PR and request changes. If a Maintainer | ||
Requests changes they need to provide an explanation regarding what changes | ||
should be added and justification of their importance. Reviews requesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good point, thanks for making sure it's there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent. Thanks so much for writing this up, @tsalo ! I know it's very difficult to express all of these ideas in writing so clearly. How do we want to approve this as our file?
I figured that folks might fluctuate in their personal time commitments, so I was reticent to sort by time (it will make the diffs for PRs changing time commitments messier). That said, I'm not married to the alphabetical sorting, but I'm also not concerned about the order personally.
Thank you, although it's almost all just copied over and lightly adapted from the BIDS specification.
I think we should probably discuss it on the next call, rather than using the approach proposed in the file to vote on the file itself. |
I'm sorry, I completely missed your response @tsalo. RE: alphabetical order. I agree that it's an arbitrary choice, but I think trying to measure involvement with the project is hard, and costs effort that would better be allocated elsewhere. If it makes you feel better, we could be unique and do reverse-alphabetical, which is an equally arbitrary ordering :- ) RE: spec. It's still work, and I appreciate it. The projects are in many ways quite different. RE: approval. I agree, a discussion on the call would be good. Hopefully despite the pandemic most will be able to make it. |
Per the April devs call, we may want to wait on @KirstieJane's input regarding triage before merging this PR. |
This issue has been automatically marked as stale because it has not had any activity in 90 days. It will be closed in 600 days if no further activity occurs. Thank you for your contributions to tedana:tada: ! |
I'm going to pause this, as we're moving our development of the decision-making file to a Google Doc for the foreseeable future. I will copy over the changes to this PR once they're finalized in the Doc. |
In response to the last dev call and #607, I'm going to start drafting a PR to put all the info in the decision making document into the documentation. It's not always obvious where things should go so I wanted to run my plan by others. The first question is whether I should add onto this PR or should I open a new PR and we'll close this one? Thoughts @tsalo @emdupre @jbteves @eurunuela ? Most of the current info is in the Contributing to tedana docs page. I'd remove Governance as a subheading on that page and make it a distinct page that will contain the info on the steering committee composition & role as well as the decision making procedure. This PR also made it a distinct PR, but didn't yet link it to the rest fo the documentation. Remaining on the Contributing to tedana page will be the link to the practical contributors' guide and the development philosophy. The tedana project scope from the governance doc will be added to the development philosophy section. The other potential place to edit is the The last big part is updating the contributors section to be more descriptive. That effort could be included in the same PR or a separate PR. We talked about making a distinct PR for that during the last dev call and I think that does make sense. |
I'd vote new PR, but open to other suggestions. We can make the contributing section expansion a different PR, I think that makes sense if we feel the other two are more or less stable. |
I'm happy to close this PR given how out-of-date it is.
Agreed. A separate PR sounds good. I don't want to close this PR until this discussion is complete, though. @handwerkerd When you're happy with the state of that discussion, would you mind closing this PR? |
OK. When I open the new draft PR, I'll close this one. |
I opened #615 so I'm closing this PR. |
Closes #526.
Changes proposed in this pull request: