Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Governance update #615

Merged
merged 47 commits into from
Dec 8, 2020
Merged

Conversation

handwerkerd
Copy link
Member

@handwerkerd handwerkerd commented Oct 20, 2020

Closes #607.

Changes proposed in this pull request:

  • Puts the governance changes drafted here into the official tedana documentation
  • This includes the transition from a BDFL to a steering committee along with procedures for making decisions
  • A project scope is also added
  • Dethrone @emdupre as BDFL (and remove the BDFL position)

Remaining to do

  • Alert all contributors about this PR to make sure they are fine with it!
  • Decide who is actually on the steering committee and add that to the documentation
  • Make sure everyone is ok with which roles they are named (or not named) under
  • Look over the list of Maintainers to make sure everyone who is there wants to be there and no one else is missing
  • Self estimates of each maintainers' time commitment to the project are currently included (and probably wrong). Do we update or remove those time commitments?
  • Make sure I didn't mess up any rst file formatting, particularly links
  • Proof read!

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #615 (0a13103) into master (e4e3e26) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          26       26           
  Lines        1965     1965           
=======================================
  Hits         1838     1838           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f64cbc...0a13103. Read the comment docs.

docs/contributing.rst Outdated Show resolved Hide resolved
docs/contributing.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
Co-authored-by: Joshua Teves <jbtevespro@gmail.com>
docs/governance.rst Outdated Show resolved Hide resolved
handwerkerd and others added 2 commits October 20, 2020 13:25
Co-authored-by: Joshua Teves <jbtevespro@gmail.com>
Co-authored-by: Joshua Teves <jbtevespro@gmail.com>
@handwerkerd
Copy link
Member Author

People who are listed as Maintainers: @dowdlelt @emdupre @rmarkello @tsalo @jbteves @eurunuela @KirstieJane Do you all want to be listed as maintainers?

Contributors in the past year who aren't currently listed as Maintainers: @javiergcas @jsheunis @CesarCaballeroGaudes @mvaziri @smoia. Do any of you want to be listed as a maintainer? (Also, we should add @smoia to the contributors' list!)

This is also in the PR, but I want to highlight here. The draft people names to leadership roles are:

  • Task manager & record keeper: Dan Handwerker
  • MR physics leader: César Caballero-Gaudes
  • Processing algorithms leade:r Eneko Uruñuela (Decomposiiton) & Dan Handwerker (Metrics & Decision Tree)
  • Collaborative programming leader: Elizabeth DuPre & Joshua Teves
  • Communications leader: Joshua Teves
  • New contributors leader: Taylor Salo
    -Multi-echo fMRI support leader: Logan Dowdle
  • Enforcer(s) of the code of conduct Elizabeth DuPre & Dan Handwerker & another volunteer (We'd like one more volunteer who is NOT super-involved with this project)

These names are based on my rapidly taken notes from the last Dev Call. If I didn't get your preferences correct, please speak up! If you want another role or co-role, please speak up! If you think there is a use for a not-yet-named role, please speak up!

@handwerkerd
Copy link
Member Author

I nominate myself for the steering committee & I take no offense if a steering committee forms that excludes me.

@jbteves
Copy link
Collaborator

jbteves commented Oct 20, 2020

@all-contributors please add @smoia for code, review, and documentation.

@allcontributors
Copy link
Contributor

@jbteves

I've put up a pull request to add @smoia! 🎉

@tsalo
Copy link
Member

tsalo commented Oct 20, 2020

Yes, I would like to be listed as a Maintainer. Thank you.

@jbteves
Copy link
Collaborator

jbteves commented Oct 20, 2020

Yes, me too, thanks.

@dowdlelt
Copy link
Collaborator

Good with it, thanks

@eurunuela
Copy link
Collaborator

eurunuela commented Oct 20, 2020

I'm also happy with this! And yes, I'd like to be listed as maintainer.

Thank you Dan!

@emdupre
Copy link
Member

emdupre commented Oct 20, 2020

This looks good to me, thank you @handwerkerd ! I'm excited to move beyond the BDFL structure 🚀

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @handwerkerd ! I have a few questions, mostly around maintainers vs community members. Excited for this next step !

docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
handwerkerd and others added 2 commits October 20, 2020 21:24
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
@handwerkerd
Copy link
Member Author

Thoughts regarding moving forward with this? It sounds like I should do a non-trivial reorganization with some content edits. I'm fine with that, but is that easier to do in a PR or should we go back to a doc where several of us can make inline comments & edits? I don't want to do anything significant without some feedback from @tsalo.

typo/working fixes suggested by stalo

Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
docs/contributing.rst Outdated Show resolved Hide resolved
emdupre
emdupre previously approved these changes Dec 7, 2020
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good ! I made a few wording suggestions and a potential clarification on the "who dismisses reviews" question that @tsalo brought up.

Very excited for this next step ! 🎉 ✨

docs/contributing.rst Outdated Show resolved Hide resolved
docs/contributing.rst Outdated Show resolved Hide resolved
docs/contributing.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved
docs/governance.rst Outdated Show resolved Hide resolved

(1) The author closing the PR without merging
(2) The reviewer accepting requested changes or
(3) The dismissing their review, so that the PR can be approved and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested it should be the reviewer dismissing their own review. Let us know if that's not what you were thinking @handwerkerd ?

Language clarifications from emdupre's review

Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
@handwerkerd handwerkerd dismissed stale reviews from emdupre via db1aab6 December 7, 2020 19:40
@jbteves
Copy link
Collaborator

jbteves commented Dec 7, 2020

What on Earth? Now RTD is failing but all of the subcommands indicate an exit code of 0.

@handwerkerd
Copy link
Member Author

I think all comments have been addressed and everyone on the steering committee has already approved a near-final version of this PR. We still need at least two re-approvals. Assuming I get them, I'll plan to squash & merge this Tuesday night EST.

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Since presumably CI passed, I think we're finally completely ready. Amazing work, all who were involved, and a momentous occasion! 🚀
Approved.

Copy link
Collaborator

@dowdlelt dowdlelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work folks, and for catching all those things I missed (and fun [wrong] use of latin!)

@handwerkerd handwerkerd merged commit 45e5ad7 into ME-ICA:master Dec 8, 2020
@handwerkerd handwerkerd deleted the GovernanceUpdate branch December 8, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roles in tedana: Call for nominations and discussion
9 participants