-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Governance update #615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 26 26
Lines 1965 1965
=======================================
Hits 1838 1838
Misses 127 127 Continue to review full report at Codecov.
|
Co-authored-by: Joshua Teves <jbtevespro@gmail.com>
People who are listed as Maintainers: @dowdlelt @emdupre @rmarkello @tsalo @jbteves @eurunuela @KirstieJane Do you all want to be listed as maintainers? Contributors in the past year who aren't currently listed as Maintainers: @javiergcas @jsheunis @CesarCaballeroGaudes @mvaziri @smoia. Do any of you want to be listed as a maintainer? (Also, we should add @smoia to the contributors' list!) This is also in the PR, but I want to highlight here. The draft people names to leadership roles are:
These names are based on my rapidly taken notes from the last Dev Call. If I didn't get your preferences correct, please speak up! If you want another role or co-role, please speak up! If you think there is a use for a not-yet-named role, please speak up! |
I nominate myself for the steering committee & I take no offense if a steering committee forms that excludes me. |
@all-contributors please add @smoia for code, review, and documentation. |
I've put up a pull request to add @smoia! 🎉 |
Yes, I would like to be listed as a Maintainer. Thank you. |
Yes, me too, thanks. |
Good with it, thanks |
I'm also happy with this! And yes, I'd like to be listed as maintainer. Thank you Dan! |
This looks good to me, thank you @handwerkerd ! I'm excited to move beyond the BDFL structure 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @handwerkerd ! I have a few questions, mostly around maintainers vs community members. Excited for this next step !
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
Thoughts regarding moving forward with this? It sounds like I should do a non-trivial reorganization with some content edits. I'm fine with that, but is that easier to do in a PR or should we go back to a doc where several of us can make inline comments & edits? I don't want to do anything significant without some feedback from @tsalo. |
typo/working fixes suggested by stalo Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
78cf9e8
grammer fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good ! I made a few wording suggestions and a potential clarification on the "who dismisses reviews" question that @tsalo brought up.
Very excited for this next step ! 🎉 ✨
docs/governance.rst
Outdated
|
||
(1) The author closing the PR without merging | ||
(2) The reviewer accepting requested changes or | ||
(3) The dismissing their review, so that the PR can be approved and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested it should be the reviewer dismissing their own review. Let us know if that's not what you were thinking @handwerkerd ?
Language clarifications from emdupre's review Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
What on Earth? Now RTD is failing but all of the subcommands indicate an exit code of 0. |
I think all comments have been addressed and everyone on the steering committee has already approved a near-final version of this PR. We still need at least two re-approvals. Assuming I get them, I'll plan to squash & merge this Tuesday night EST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Since presumably CI passed, I think we're finally completely ready. Amazing work, all who were involved, and a momentous occasion! 🚀
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work folks, and for catching all those things I missed (and fun [wrong] use of latin!)
Closes #607.
Changes proposed in this pull request:
Remaining to do