Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Jupyter tests #51

Merged
merged 4 commits into from
Oct 3, 2022
Merged

update Jupyter tests #51

merged 4 commits into from
Oct 3, 2022

Conversation

kafonek
Copy link
Contributor

@kafonek kafonek commented Sep 30, 2022

Update jupyter backend tests to use a pattern that can move the asyncio loop forward until it sees certain message types. This also helps highlight a problem in test_reconnection where we sometimes miss status messages while we're disconnecting / reconnecting a socket. That will be fixed in the next PR.

@kafonek
Copy link
Contributor Author

kafonek commented Sep 30, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Sep 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #51 (62b99db) into main (71313c8) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   94.58%   94.38%   -0.21%     
==========================================
  Files           8        8              
  Lines         499      499              
==========================================
- Hits          472      471       -1     
- Misses         27       28       +1     
Impacted Files Coverage Δ
sending/backends/jupyter.py 96.51% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71313c8...62b99db. Read the comment docs.

@kafonek kafonek marked this pull request as ready for review September 30, 2022 18:15
@kafonek kafonek requested a review from a team September 30, 2022 18:15
tests/test_jupyter_backend.py Show resolved Hide resolved
@kafonek kafonek merged commit ec0e63c into main Oct 3, 2022
@kafonek kafonek deleted the mrk/update-jupyter-tests branch October 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants