ZMQ socket monitoring refactor #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Merged
kafonek
force-pushed
the
mrk/zmq-polling-refactor
branch
from
62dc3b6
to
e276894
Compare
kafonek
force-pushed
the
mrk/zmq-polling-refactor
branch
from
e276894
to
a352b19
Compare
tizz98
approved these changes
Sep 30, 2022
kafonek
force-pushed
the
mrk/zmq-polling-refactor
branch
from
a352b19
to
9f0860e
Compare
kafonek
force-pushed
the
mrk/zmq-polling-refactor
branch
from
46c3970
to
3e6ce75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the situation where we sometimes miss messages while cycling (disconnect/reconnect) a socket. It accomplishes that by changing the syntax to be more event driven rather than looping as much.