feat(tables)!: add $isLoading prop to SimpleTable.Td, normalize all tables margins/heights & checkboxes #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `$isLoading` prop to `SimpleTable.Td (& `TableWithSelectableRows.Td`) - add `$width` prop to `SimpleTable.Th` (& `TableWithSelectableRows.Th`) - add & expose `SimpleTable.CellLoader` (& `TableWithSelectableRows.CellLoader`) - fix ellipsis when `SimpleTable.Th` width is set while not set in `SimpleTable.Td` (// `TableWithSelectableRows`) - deprecate `$width` prop from `TableWithSelectableRows.Td`
ivangabriele
force-pushed
the
ivan/feat-tables-add-isLoading-prop-to-SimpleTable.Td
branch
from
d8eb90b
to
faf9342
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 57.39% 57.39%
=======================================
Files 55 55
Lines 805 805
Branches 274 267 -7
=======================================
Hits 462 462
- Misses 327 343 +16
+ Partials 16 0 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
claire2212
approved these changes
May 23, 2024
ivangabriele
force-pushed
the
ivan/feat-tables-add-isLoading-prop-to-SimpleTable.Td
branch
from
e5b5f10
to
90e870c
Compare
ivangabriele
changed the title
BREAKING CHANGE: - Remove `isChecked` prop in `TableWithSelectableRows.RowCheckbox`, replaced by native `checked` prop. - Remove `isIndeterminate` prop in `TableWithSelectableRows.RowCheckbox`, replaced by original Rsuite `indeterminate` prop. - Remove `$isHighlighted` prop in `TableWithSelectableRows.Td`, replaced by the same prop on `TableWithSelectableRows.BodyTr`. - In order to work properly with `RowCheckbox`, `TableWithSelectableRows` now requires `<Table $withRowCheckbox />`. - Following the `SimpleTable` & `TableWithSelectableRows` margins/heights normalization, including a few hacks, it may break some UI widths & heights. - Please check `TableWithSelectableRows.stories.tsx` to see a full example on how to use/update it. - As shown in the story, be careful **NOT** to wrap the checkbox table header cell within `<TableWithSelectableRows.SortContainer />` since the flex display breaks its internal positioning.
ivangabriele
force-pushed
the
ivan/feat-tables-add-isLoading-prop-to-SimpleTable.Td
branch
from
90e870c
to
cd9d2f1
Compare
louptheron
approved these changes
May 24, 2024
claire2212
approved these changes
May 24, 2024
ivangabriele
deleted the
ivan/feat-tables-add-isLoading-prop-to-SimpleTable.Td
branch
|
🎉 This PR is included in version 18.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
isCheckedprop inTableWithSelectableRows.RowCheckbox, replaced by nativecheckedprop.isIndeterminateprop inTableWithSelectableRows.RowCheckbox, replaced by original Rsuiteindeterminateprop.$isHighlightedprop inTableWithSelectableRows.Td, replaced by the same prop onTableWithSelectableRows.BodyTr.RowCheckbox,TableWithSelectableRowsnow requires<Table $withRowCheckbox />.SimpleTable&TableWithSelectableRowsmargins/heights normalization, including a few hacks,it may break some UI widths & heights.
TableWithSelectableRows.stories.tsxto see a full example on how to use/update it.within
<TableWithSelectableRows.SortContainer />since the flex display breaks its internal positioning.Features
$isLoadingprop toSimpleTable.Td (&TableWithSelectableRows.Td`)$widthprop toSimpleTable.Th(&TableWithSelectableRows.Th)SimpleTable.CellLoader(&TableWithSelectableRows.CellLoader)https://xd.adobe.com/view/e5dc3e34-ae1f-4a6d-be9a-5d2a70e54eff-b08f/screen/fefd4bd0-176f-4fad-8247-1603a57564f6/specs/
Fixes
SimpleTable.Thwidth is set while not set inSimpleTable.Td(//TableWithSelectableRows)deprecate(removed by breaking change)$widthprop fromTableWithSelectableRows.TdRelated Pull Requests & Issues
Preview URL
https://637e01cf5934a2ae881ccc9d-bebahrewee.chromatic.com/
Screenshots