[Moyens et unités] Finalisation du back-office #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@louptheron @thoomasbro @claire2212 J'ai fait mon premier commit de refacto pour bien séparer la logique de "rôle" entre les entités et les DTOs, comme on en a parlé ensemble (tu n'étais pas là Thomas, mais tu comprendras en lisant le code ^^). Je vous poke du coup pour faire une revue de ce changement, voir si on est bien aligné. Pour info, ce commit ne fait que ça, je vais régler les autres points de review de ma PR précédentes dans d'autres commits. |
ivangabriele
force-pushed
the
ivan/add-control-units-archiving-and-deletion-in-backoffice
branch
3 times, most recently
from
b12cade
to
d74460c
Compare
ivangabriele
force-pushed
the
ivan/add-control-units-archiving-and-deletion-in-backoffice
branch
from
d74460c
to
21d1ac8
Compare
ivangabriele
force-pushed
the
ivan/add-control-units-archiving-and-deletion-in-backoffice
branch
from
21d1ac8
to
6666073
Compare
louptheron
reviewed
Sep 28, 2023
...otlin/fr/gouv/cacem/monitorenv/domain/use_cases/administration/dtos/FullAdministrationDTO.kt
Outdated
Show resolved
Hide resolved
...otlin/fr/gouv/cacem/monitorenv/domain/use_cases/administration/dtos/FullAdministrationDTO.kt
Show resolved
Hide resolved
...lin/fr/gouv/cacem/monitorenv/domain/use_cases/controlUnit/dtos/FullControlUnitResourceDTO.kt
Outdated
Show resolved
Hide resolved
...torenv/infrastructure/api/adapters/publicapi/inputs/CreateOrUpdateAdministrationDataInput.kt
Show resolved
Hide resolved
...kotlin/fr/gouv/cacem/monitorenv/infrastructure/database/repositories/services/BaseService.kt
Outdated
Show resolved
Hide resolved
...cem/monitorenv/infrastructure/database/repositories/JpaControlUnitContactRepositoryITests.kt
Show resolved
Hide resolved
...em/monitorenv/infrastructure/database/repositories/JpaControlUnitResourceRepositoryITests.kt
Outdated
Show resolved
Hide resolved
ivangabriele
force-pushed
the
ivan/add-control-units-archiving-and-deletion-in-backoffice
branch
from
6933ed5
to
bf19d7c
Compare
louptheron
reviewed
Oct 3, 2023
| @@ -0,0 +1,7 @@ | |||
| -- There are already production administrations inserted by `V0.060__create_administrations` | |||
| -- We add a few more here for testing purpose | |||
| INSERT INTO public.administrations | |||
There was a problem hiding this comment.
Mini truc : le nommage du fichier est plutôt V666.1__Insert_dummy_administrations.sql avec un "I" majuscule
There was a problem hiding this comment.
Alors en fait je n'avais pas vu mais dans Env tous les fichiers SQL de migration/dummy data sont en minuscule contrairement à Fish :X
louptheron
approved these changes
Oct 3, 2023
claire2212
approved these changes
Oct 3, 2023
ivangabriele
deleted the
ivan/add-control-units-archiving-and-deletion-in-backoffice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues