Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Préavis - Afficher un PNO -12m en lecture seule pour les unités #3242

Closed
louptheron opened this issue May 29, 2024 · 3 comments · Fixed by #3270, #3382 or #3387
Closed

Préavis - Afficher un PNO -12m en lecture seule pour les unités #3242

louptheron opened this issue May 29, 2024 · 3 comments · Fixed by #3270, #3382 or #3387
Assignees
@AdelineCelier
Labels
dev feat. enhancement feature enhancement

Comments

@louptheron
Copy link
Collaborator

louptheron commented May 29, 2024 •
edited
Loading

  • Retirer le bouton "Ajouter un préavis"
  • Retirer le bouton "Diffuser le préavis"
@louptheron louptheron added dev feat. enhancement feature enhancement labels May 29, 2024
@louptheron louptheron moved this to To do in Board MonitorFish May 29, 2024
@louptheron louptheron mentioned this issue May 29, 2024
Closed
27 tasks
@louptheron louptheron mentioned this issue Jun 10, 2024
Merged
1 task
louptheron added a commit that referenced this issue Jun 14, 2024
@louptheron
Préavis - Affichage des PNO manuels (#3270)
fb4b78b 
## Linked issues

- Resolve #3242

----

- [ ] Tests E2E (Cypress)
@github-project-automation github-project-automation bot moved this from To do to To deploy in INT for review in Board MonitorFish Jun 14, 2024
@ivangabriele ivangabriele moved this from To deploy in INT for review to To review in INT in Board MonitorFish Jun 20, 2024
@AdelineCelier
Copy link
Collaborator

AdelineCelier commented Jun 25, 2024 •
edited
Loading

@louptheron petit bug repéré + petits points UX/UI:

  • certains préavis saisis manuellement ne s'affichent pas comme des préavis manuels (cf. captures ci-dessous) 👍
  • revoir le titre donné aux vues détaillées des préavis (j'ai retouché les maquettes depuis pour simplifier, yavait trop d'acronymes entre "PNO" et les noms de segments)
    • soit "Préavis navire ≥ 12 m" sans segments 👍
    • soit "Préavis navire < 12 m" sans segments 👍
  • les deux boutons "fermer" et "télécharger les docs" sont collés, il faut 8 px d'écart entre les deux 👍

Ex. 1 sur le Prospector
image

Ex. 2 sur le Talion
image

@AdelineCelier AdelineCelier moved this from To review in INT to To do in Board MonitorFish Jun 25, 2024
@louptheron louptheron moved this from To do to In progress in Board MonitorFish Jul 5, 2024
@louptheron louptheron mentioned this issue Jul 9, 2024
Merged
1 task
@louptheron louptheron moved this from In progress to In Code Review in Board MonitorFish Jul 9, 2024
louptheron added a commit that referenced this issue Jul 10, 2024
@louptheron
Préavis - Diverses corrections (#3382)
e761ce8 
## Linked issues

- Resolve #3242
- Resolve #3240 
- Resolve #2843

----

- [ ] Tests E2E (Cypress)
@louptheron louptheron moved this from In Code Review to To review in INT in Board MonitorFish Jul 10, 2024
@AdelineCelier
Copy link
Collaborator

@louptheron dans la side window, les menus pour accéder aux missions, aux alertes et aux avaries VMS s'affichent, c'est pas normal si ?

@AdelineCelier AdelineCelier moved this from To review in INT to To do in Board MonitorFish Jul 10, 2024
@louptheron louptheron moved this from To do to In Code Review in Board MonitorFish Jul 11, 2024
@louptheron louptheron mentioned this issue Jul 11, 2024
Merged
1 task
louptheron added a commit that referenced this issue Jul 12, 2024
@louptheron
Préavis - Correction UX/UI (#3387)
9a02d85 
## Linked issues

- Resolve #3242
- Resolve #3240
- Resolve #3319
- Resolve #2843
- Resolve #3241
- Resolve #3317
- Resolve #2869

----

- [ ] Tests E2E (Cypress)
@louptheron louptheron moved this from In Code Review to To deploy in INT for review in Board MonitorFish Jul 12, 2024
@louptheron louptheron moved this from To deploy in INT for review to To review in INT in Board MonitorFish Jul 12, 2024
@AdelineCelier
Copy link
Collaborator

C'est bon, les menus sont bien retirés.

@AdelineCelier AdelineCelier moved this from To review in INT to Done in Board MonitorFish Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdelineCelier AdelineCelier

Labels
dev feat. enhancement feature enhancement
Projects
Board MonitorFish
Status: Done
Milestone
No milestone
3 participants
@ivangabriele @louptheron @AdelineCelier