Skip to content

Commit

Permalink
Point wind arrow in the direction the wind is flowing (#3022)
Browse files Browse the repository at this point in the history
Fixes #3019

The previous implementation had the arrow pointing in to the wind. When
the wind blows from the north (0 degrees), the arrow should point
straight down. In other words, no rotation of the arrow-down symbol.
When the wind blows from the south (180 degrees), the arrow should point
straight up (I.e. the arrow down symbol rotated 180 degrees).

Co-authored-by: Magnus Marthinsen <magmar@online.no>
  • Loading branch information
MagMar94 and Magnus Marthinsen authored Jan 22, 2023
1 parent 2e2962d commit 67e4dba
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ _This release is scheduled to be released on 2023-04-01._
- Fix message display with HTML code into alert module (#2828)
- Fix typo into french translation
- Yr wind direction is no longer inverted
- The wind direction arrow now points in the direction the wind is flowing, not into the wind.

## [2.22.0] - 2023-01-01

Expand Down
2 changes: 1 addition & 1 deletion modules/default/weather/current.njk
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{% if config.showWindDirection %}
<sup>
{% if config.showWindDirectionAsArrow %}
<i class="fas fa-long-arrow-alt-up" style="transform:rotate({{ current.windFromDirection }}deg);"></i>
<i class="fas fa-long-arrow-alt-down" style="transform:rotate({{ current.windFromDirection }}deg);"></i>
{% else %}
{{ current.cardinalWindDirection() | translate }}
{% endif %}
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/modules/weather_current_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe("Weather module", () => {
});

it("should render windDirection with an arrow", async () => {
const elem = await helpers.waitForElement(".weather .normal.medium sup i.fa-long-arrow-alt-up");
const elem = await helpers.waitForElement(".weather .normal.medium sup i.fa-long-arrow-alt-down");
expect(elem).not.toBe(null);
expect(elem.outerHTML).toContain("transform:rotate(250deg);");
});
Expand Down

0 comments on commit 67e4dba

Please sign in to comment.