UK Met Office DataHub weather provider #2058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a new weather provider that uses the Met Office's new DataHub API (their existing DataPoint service will eventually be shut down, to be replaced by this one).
I have written this provider to return precipitation as a probability, in line with the existing Met Office provider (although it can also supply absolute values in mm). As such, there needs to be a small addition to
weather.js
where theif
statement checks for the existing Met Office module when returning precipitation units.The documentation for the weather module will also need to be updated (if approved, of course).
It solves a created issue - editing weather.js to check for this provider when returning precipitation units
N/A
Adds a provider for the Met Office's new API.
N/A