Create Thai Language file

[tomzt]

Create Thai Language file.
Translation from English to Thai.

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

1. Base your pull requests against the develop branch.

2. Include these infos in the description:

• Does the pull request solve a related issue?
• If so, can you reference the issue like this Fixes #<issue_number>?
• What does the pull request accomplish? Use a list if needed.
• If it includes major visual changes please add screenshots.

3. Please run npm run lint:prettier before submitting so that
   style issues are fixed.

4. Don't forget to add an entry about your changes to
   the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

[rejas]

please also rename the file to translations/th.json

[rejas]

this just got changed and split into two keys:

"PRECIP_POP": "PoP",
"PRECIP_AMOUNT": "Precipitation amount",

[tomzt]

Add already

[rejas]

thanks for your pullrequest. small changes necessary

please also add an entry to the CHANGELOG.md file

[tomzt]

add it

[tomzt]

Add already

[codecov-commenter]

Codecov Report

Merging #3028 (be7b081) into master (2eaf9df) will increase coverage by 0.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3028      +/-   ##
==========================================
+ Coverage   21.69%   21.77%   +0.07%     
==========================================
  Files          52       52              
  Lines       11424    11424              
==========================================
+ Hits         2479     2488       +9     
+ Misses       8945     8936       -9     

Impacted Files	Coverage Δ
modules/default/updatenotification/node_helper.js	80.00% <0.00%> (+12.85%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[rejas]

Crap, I overlooked that it was based against master... Can we revert that on master @MichMich @khassel ?

[MichMich]

Not without creating an additional commit. :(

[rejas]

So, we are probably stuck here (or we force-push the commit before from master)....

[MichMich]

Force push could lead to a lot of issues when others have already pulled. :(

[rejas]

Maybe we can protect the master branch from pushing PRs to it (except develop)? https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule

[MichMich]

It's already a protected branch. Maybe I'm missing something?

[rejas]

Seems like that usecase isnt possible with github outofthebox.
But this action could be something we add to our workflow: https://github.com/marketplace/actions/check-base-branch

[khassel]

upsi, glad I'm not the famous one this time ;)

Did you overlook the wrong branch when merging in the WebUI (could happen to me too)?

But this action could be something we add to our workflow: https://github.com/marketplace/actions/check-base-branch

we should test this.

Related: To prevent pushing to the wrong repo (original instead own fork) I use a non existing push url (I would have already pushed without):

$ git remote -v
k13     git@github.com:khassel/MagicMirror.git (fetch)
k13     git@github.com:khassel/MagicMirror.git (push)
origin  git@github.com:MichMich/MagicMirror.git (fetch)
origin  fake@github.com (push)

[rejas]

we should test this.

Already working on something: rejas#7

[rejas]

Did you overlook the wrong branch when merging in the WebUI (could happen to me too)?

yes :-)