Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow #7

Closed
wants to merge 3 commits into from
Closed

Update workflow #7

wants to merge 3 commits into from

Conversation

rejas
Copy link
Owner

@rejas rejas commented Feb 7, 2023

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.

  2. Include these infos in the description:

  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.

  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Base: 22.87% // Head: 22.95% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (bafa394) compared to base (e24dfa6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #7      +/-   ##
===========================================
+ Coverage    22.87%   22.95%   +0.07%     
===========================================
  Files           52       52              
  Lines        11541    11541              
===========================================
+ Hits          2640     2649       +9     
+ Misses        8901     8892       -9     
Impacted Files Coverage Δ
modules/default/updatenotification/node_helper.js 90.27% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rejas rejas force-pushed the misc/enforce_develop_branch branch 2 times, most recently from 690e9d7 to 565c05b Compare February 7, 2023 18:54
@rejas rejas force-pushed the misc/enforce_develop_branch branch 6 times, most recently from ca7a27e to 939f02c Compare February 8, 2023 21:08
@rejas rejas added the question label Feb 8, 2023
@rejas rejas force-pushed the misc/enforce_develop_branch branch 6 times, most recently from be820d8 to 0ef5088 Compare February 15, 2023 21:34
@rejas rejas force-pushed the misc/enforce_develop_branch branch 6 times, most recently from bafa394 to 9f49a11 Compare February 16, 2023 08:51
@rejas rejas closed this Feb 16, 2023
@rejas rejas deleted the misc/enforce_develop_branch branch February 16, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants