use IdealForegroundColorBrush in title bar elements #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea! |
punker76
added a commit
that referenced
this pull request
Oct 26, 2014
…n-title use IdealForegroundColorBrush in title bar elements
|
Just noticed that this broke the minimize/maximize/close buttons on the clean window:
|
|
That’s strange, it works for me. I’m going to create a new branch and a new PR. I did it wrong at first by pushing to the master branch of my repository, it’s better to fix that now. |
|
@thoemmi Yep, it's fixed already |
flagbug
pushed a commit
that referenced
this pull request
Nov 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a bright theme (such as yellow), you can hardly read the elements in the title bar. With this PR I suggest to use
IdealForegroundColorwhere appropriate.I'm not sure whether I've changed the correct elements. Please review my changes carefully. 😟
Before:
After:
