Fix aesthetics of errorbars (#560)

Got this wrong, the first two args are always x/y and the `direction =
:x` attribute just flips the error direction from there, unlike
`rangebars`.

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fixed aesthetics of `errorbar` so that x and y stay labelled correctly when using `direction = :x` [#560](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/560).
 - Added ability to specify `title`, `subtitle` and `footnotes` plus settings in the `draw` function [#556](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/556).
 
 ## v0.8.7 - 2024-09-06

src/aesthetics.jl

@@ -252,14 +252,8 @@ function aesthetic_mapping(::Type{Errorbars}, i::Int)
         ])
     ]
     dictionary([
-        1 => :direction => dictionary([
-            :x => AesY,
-            :y => AesX,
-        ]),
-        2 => :direction => dictionary([
-            :x => AesX,
-            :y => AesY,
-        ]),
+        1 => AesX,
+        2 => AesY,
         3 => :direction => dictionary([
             :x => AesDeltaX,
             :y => AesDeltaY,

test/reference_tests.jl

@@ -196,27 +196,27 @@ reftest("rangebars cat color direction x") do
 end
 
 reftest("errorbars") do
-    data((; x = 1:4, y = 1:4, err = 2:5)) * mapping(:x, :y, :err) *
+    data((; x = ["A", "B", "C", "D"], y = 5:8, err = 2:5)) * mapping(:x, :y, :err) *
         visual(Errorbars) |> draw
 end
 
 reftest("errorbars direction x") do
-    data((; x = 1:4, y = 1:4, err = 2:5)) * mapping(:x, :y, :err) *
+    data((; x = ["A", "B", "C", "D"], y = 5:8, err = 2:5)) * mapping(:x, :y, :err) *
         visual(Errorbars; direction = :x) |> draw
 end
 
 reftest("errorbars cat color direction x") do
-    data((; x = 1:4, y = 1:4, err = 2:5, z = 1:4)) * mapping(:x, :y, :err, color = :z => nonnumeric) *
+    data((; x = ["A", "B", "C", "D"], y = 5:8, err = 2:5, z = 1:4)) * mapping(:x, :y, :err, color = :z => nonnumeric) *
         visual(Errorbars; direction = :x) |> draw
 end
 
 reftest("errorbars cat color") do
-    data((; x = 1:4, y = 1:4, err = 2:5, z = 1:4)) * mapping(:x, :y, :err, color = :z => nonnumeric) *
+    data((; x = ["A", "B", "C", "D"], y = 5:8, err = 2:5, z = 1:4)) * mapping(:x, :y, :err, color = :z => nonnumeric) *
         visual(Errorbars) |> draw
 end
 
 reftest("errorbars low high") do
-    data((; x = 1:4, y = 1:4, errlow = [0.1, 0.2, 0.3, 0.4], errhigh = [0.4, 0.2, 0.3, 0.1])) * mapping(:x, :y, :errlow, :errhigh) *
+    data((; x = ["A", "B", "C", "D"], y = 5:8, errlow = [0.1, 0.2, 0.3, 0.4], errhigh = [0.4, 0.2, 0.3, 0.1])) * mapping(:x, :y, :errlow, :errhigh) *
         visual(Errorbars) |> draw
 end