Consolidated Service/VM quota validation. #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaafitz
force-pushed
the
consolidated_quota
branch
from
4b35aa4
to
69e63b7
Compare
| @@ -0,0 +1,457 @@ | |||
|
|
|||
| def request_info | |||
| type = $evm.root['quota_type'] | |||
There was a problem hiding this comment.
@tinaafitz
Is the quota_type going to be specified in the instance or in the root object?
tinaafitz
force-pushed
the
consolidated_quota
branch
2 times, most recently
from
8b37ff7
to
708576b
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
tinaafitz
force-pushed
the
consolidated_quota
branch
2 times, most recently
from
a59d158
to
b073703
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
tinaafitz
force-pushed
the
consolidated_quota
branch
from
b073703
to
6852363
Compare
|
@mkanoor |
| end | ||
|
|
||
| def parent_model_value(attr) | ||
| value = $evm.parent[attr].to_i |
There was a problem hiding this comment.
@tinaafitz
Should we check if $evm.parent exists and is not nil, raise an exception if missing.
tinaafitz
force-pushed
the
consolidated_quota
branch
from
e0f89e2
to
d4660d2
Compare
| quota_values(model_attribute, tag_name) | ||
| end | ||
|
|
||
| @source = $evm.root['quota_source'] |
There was a problem hiding this comment.
@tinaafitz
We should check if @source is nil and raise exception
tinaafitz
force-pushed
the
consolidated_quota
branch
9 times, most recently
from
6d13819
to
a58e361
Compare
following issues: https://bugzilla.redhat.com/show_bug.cgi?id=1254211 when quota exceeds Group Allocated Memory always shows "0.00GB" in last message of request details page (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1248747 service :quota : Provisioning quota for CPU , Memory and Storage doesn't work (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1254882 Provisioning quota for CPU/Mem/Storage doesn't work for cloud providers (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1126934 [RFE] Quota enforcement based on used space (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1249772 [RFE] Service :quota : Should be able to apply VM quota to service (edit)
changed quota schema/instances to reflect method changes.
model/tag limit values.
tinaafitz
force-pushed
the
consolidated_quota
branch
from
a58e361
to
f142b50
Compare
|
Checked commits tinaafitz/manageiq@1250288~...f142b50 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
👍 |
|
@tinaafitz Should this still be WIP? |
tinaafitz
changed the title
|
@gmcculloug |
|
Thanks for reviewing @mkanoor. |
gmcculloug
added a commit
that referenced
this pull request
Oct 27, 2015
Consolidated Service/VM quota validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidating quota code to help facilitate resolution for the following issues:
https://bugzilla.redhat.com/show_bug.cgi?id=1254211
when quota exceeds Group Allocated Memory always shows "0.00GB"
in last message of request details page (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=1248747
service :quota : Provisioning quota for CPU , Memory and Storage
doesn't work (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=1254882
Provisioning quota for CPU/Mem/Storage doesn't work
for cloud providers (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=1126934
[RFE] Quota enforcement based on used space (edit)
https://bugzilla.redhat.com/show_bug.cgi?id=1249772
[RFE] Service :quota : Should be able to apply VM quota to service (edit)