-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Tenant quota changes #4936
Conversation
089ac01
to
7073c5b
Compare
7073c5b
to
7c6e317
Compare
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
following issues: https://bugzilla.redhat.com/show_bug.cgi?id=1254211 when quota exceeds Group Allocated Memory always shows "0.00GB" in last message of request details page (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1248747 service :quota : Provisioning quota for CPU , Memory and Storage doesn't work (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1254882 Provisioning quota for CPU/Mem/Storage doesn't work for cloud providers (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1126934 [RFE] Quota enforcement based on used space (edit) https://bugzilla.redhat.com/show_bug.cgi?id=1249772 [RFE] Service :quota : Should be able to apply VM quota to service (edit)
changed quota schema/instances to reflect method changes.
model/tag limit values.
7c6e317
to
c06a3ad
Compare
Checked commits tinaafitz/manageiq@0e5c7cc~...c06a3ad with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 db/fixtures/ae_datastore/ManageIQ/System/CommonMethods/QuotaMethods.class/methods/limits.rb
|
fields: | ||
- ValidateQuotas: | ||
value: "/System/Commonmethods/quota/vm_quota" | ||
on_entry: "#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinaafitz
Is the # needed won't a missing on_entry also work here
ws = run_automate_method(@miq_provision_request) | ||
root = ws.root | ||
quota_source = root['quota_source'] | ||
expect(root['quota_source']).to be_kind_of(MiqAeMethodService::MiqAeServiceMiqGroup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinaafitz
Should this be MiqAeMethodService::MiqAeServiceTenant?
@tinaafitz |
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
Tenant quota changes included in #4338 |
Changed consolidated quota to use tenants as default and changed methods to collect tenant data.
These changes rely on #4338