Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tenant quota changes #4936

Closed
wants to merge 12 commits into from

Conversation

tinaafitz
Copy link
Member

Changed consolidated quota to use tenants as default and changed methods to collect tenant data.

These changes rely on #4338

@miq-bot
Copy link
Member

miq-bot commented Oct 21, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Oct 21, 2015

Checked commits tinaafitz/manageiq@0e5c7cc~...c06a3ad with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
12 files checked, 2 offenses detected

db/fixtures/ae_datastore/ManageIQ/System/CommonMethods/QuotaMethods.class/methods/limits.rb

  • 🔹 - Line 15, Col 1 - Metrics/AbcSize - Assignment Branch Condition size for tenant_quota_values is too high. [17.72/15]
  • 🔹 - Line 78, Col 1 - Metrics/AbcSize - Assignment Branch Condition size for model_and_tag_quota_values is too high. [17/15]

fields:
- ValidateQuotas:
value: "/System/Commonmethods/quota/vm_quota"
on_entry: "#"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinaafitz
Is the # needed won't a missing on_entry also work here

ws = run_automate_method(@miq_provision_request)
root = ws.root
quota_source = root['quota_source']
expect(root['quota_source']).to be_kind_of(MiqAeMethodService::MiqAeServiceMiqGroup)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinaafitz
Should this be MiqAeMethodService::MiqAeServiceTenant?

@mkanoor
Copy link
Contributor

mkanoor commented Oct 21, 2015

@tinaafitz
If Qutoas are not being enforced can we finish the state machine right away instead of running all the way to the end and reporting.
No Quota limits set. No quota check being done

@miq-bot
Copy link
Member

miq-bot commented Oct 27, 2015

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@tinaafitz tinaafitz closed this Oct 27, 2015
@tinaafitz
Copy link
Member Author

Tenant quota changes included in #4338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants