Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deleted-project): Handle deleted Gitlab projects gracefully in project list and changelog #47

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

M0nkeySan
Copy link
Collaborator

What

Previously, when trying to fetch projects that existed in our database but were
deleted from Gitlab, the project list and changelog modal commands would fail
entirely. This was because Promise.all would reject if any single project
fetch failed.

Fix

Changes:

  • Added error handling around individual project fetches
  • Filter out non-existing Gitlab projects instead of failing
  • Ensures commands continue working even when some projects are inaccessible

Conclusion

This makes the system more resilient by allowing operations to continue even
when some referenced projects no longer exist in Gitlab.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (7f322f6) to head (36ec795).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/changelog/buildChangelogModalView.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   78.38%   78.26%   -0.13%     
==========================================
  Files          94       94              
  Lines        1897     1909      +12     
  Branches      342      345       +3     
==========================================
+ Hits         1487     1494       +7     
+ Misses        401      387      -14     
- Partials        9       28      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M0nkeySan M0nkeySan merged commit 678107d into ManoManoTech:main Oct 30, 2024
1 of 3 checks passed
pfongkye pushed a commit to pfongkye/homer that referenced this pull request Nov 7, 2024
…oject list and changelog (ManoManoTech#47)

* fix(deleted-project): Handle deleted Gitlab projects gracefully in project list and changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants