fix(deleted-project): Handle deleted Gitlab projects gracefully in project list and changelog

__tests__/project/listProjects.test.ts

@@ -26,8 +26,15 @@ describe('project > listProjects', () => {
       channelId,
       projectId: projectFixture.id + 1,
     });
+    await addProjectToChannel({
+      channelId,
+      projectId: projectFixture.id + 2,
+    });
+
     mockGitlabCall(`/projects/${projectFixture.id}`, projectFixture);
     mockGitlabCall(`/projects/${projectFixture.id + 1}`, projectFixture);
+    // This project will be removed from the list because it doesn't exist
+    mockGitlabCall(`/projects/${projectFixture.id + 2}`, {});
 
     // When
     const response = await fetch('/api/v1/homer/command', {

src/changelog/buildChangelogModalView.ts

@@ -3,6 +3,8 @@
 import { slackifyChangelog } from '@/changelog/utils/slackifyChangelog';
 import { getProjectsByChannelId } from '@/core/services/data';
 import { fetchProjectById, fetchProjectTags } from '@/core/services/gitlab';
+import { logger } from '@/core/services/logger';
+import type { GitlabProjectDetails } from '@/core/typings/GitlabProject';
 import type { SlackOption } from '@/core/typings/SlackOption';
 
 interface ChangelogModalData {
@@ -20,11 +22,21 @@
 }: ChangelogModalData): Promise<View> {
   if (channelId !== undefined && projectOptions === undefined) {
     const dataProjects = await getProjectsByChannelId(channelId);
-    const projects = await Promise.all(
-      dataProjects.map(async (dataProject) =>
-        fetchProjectById(Number(dataProject.projectId))
+    const projects: GitlabProjectDetails[] = (
+      await Promise.all(
+        dataProjects.map(async (dataProject) => {
+          try {
+            return await fetchProjectById(Number(dataProject.projectId));
+          } catch (error) {
+            logger.error(
+              `Failed to fetch project ${dataProject.projectId}:`,
+              error
+            );
+            return null;
+          }
+        })
       )
-    );
+    ).filter((project): project is GitlabProjectDetails => project !== null);
 
     projectOptions = projects
       .sort((a, b) =>

src/project/commands/list/listProjectsRequestHandler.ts

@@ -2,6 +2,7 @@ import type { Response } from 'express';
 import { HTTP_STATUS_NO_CONTENT } from '@/constants';
 import { getProjectsByChannelId } from '@/core/services/data';
 import { fetchProjectById } from '@/core/services/gitlab';
+import { logger } from '@/core/services/logger';
 import { slackBotWebClient } from '@/core/services/slack';
 import type { GitlabProjectDetails } from '@/core/typings/GitlabProject';
 import type {
@@ -20,11 +21,20 @@ export async function listProjectsRequestHandler(
 
   const { channel_id, user_id } = req.body as SlackSlashCommandResponse;
   const dataProjects = await getProjectsByChannelId(channel_id);
-  const projects = (
+  const projects: GitlabProjectDetails[] = (
     await Promise.all(
-      dataProjects.map(async ({ projectId }) => fetchProjectById(projectId))
+      dataProjects.map(async ({ projectId }) => {
+        try {
+          return await fetchProjectById(projectId);
+        } catch (error) {
+          logger.error(`Failed to fetch project ${projectId}:`, error);
+          return null;
+        }
+      })
     )
-  ).sort((a, b) => a.path_with_namespace.localeCompare(b.path_with_namespace));
+  )
+    .filter((project): project is GitlabProjectDetails => project !== null)
+    .sort((a, b) => a.path_with_namespace.localeCompare(b.path_with_namespace));
 
   const projectsParts: GitlabProjectDetails[][] = [];