-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manta-PC] Update dependencies to v0.9.12
#242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzlatarev
changed the title
Update dependencies to 0.9.12
[Manta-PC] Update dependencies to 0.9.12
Nov 2, 2021
ghzlatarev
changed the title
[Manta-PC] Update dependencies to 0.9.12
[Manta-PC] Update dependencies to Nov 2, 2021
v0.9.12
ghzlatarev
commented
Nov 2, 2021
ghzlatarev
commented
Nov 2, 2021
Dengjianping
reviewed
Nov 2, 2021
ghzlatarev
commented
Nov 4, 2021
stechu
reviewed
Nov 5, 2021
stechu
reviewed
Nov 5, 2021
ghzlatarev
commented
Nov 5, 2021
ghzlatarev
commented
Nov 5, 2021
Remember to update changelog. |
ghzlatarev
commented
Nov 5, 2021
did a manual test for the upgrade. It passed on my local machine. |
stechu
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #235
closes #239
Manta Changes
Client
3.0.8
to3.0.9
.Runtime
RelayNetwork
const to correctKusama
instead ofPolkadot
in the calamari runtime.pub type LocalOriginToLocation = ();
means that no one can becomeXcmSendOrigin
orXcmExecuteOrigin
in Calamari/Manta runtimes.type XcmExecuteFilter = Nothing;
means that even if somehow someone manages to becomesXcmExecuteOrigin
their message will be filtered out becauseNothing
s implementation ofContains
trait will always return false.pallet_session
because of API change --->DisabledValidatorsThreshold
The relevant substrate PR is staking: only disable slashed validators and keep them disabled for whole era paritytech/substrate#9448Upstream Changes
Polkadot Changes:
PeerId
s paritytech/polkadot#4036WEIGHT_PER_SECOND
Patch paritytech/polkadot#4077follow-chain
testing mode for try-runtime (and revamp CLI configs). paritytech/substrate#9788Release Checklist:
Substrate Changes:
--dev
implies--tmp
paritytech/substrate#9938Cumulus Changes:
polkadot-v0.9.12
, move torecognize
, comment on Override for AdvertisedXcmVersion default paritytech/cumulus#690statemine diffs between:
ede4d527c4fc5d84c43216b408a873625488574b -> 0.9.11
f5926c2f50df73bf36171b138241437131d76fff-> 0.9.12
Tests (Local --> Baikal)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
manta
ormanta-pc
) with right title (start with [Manta] or [Manta-PC]),Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated