This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Switch to using ss58-registry crate #9755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
A3-in_progress
bkchr
reviewed
Sep 11, 2021
|
(Added composable finance to the ss58 crate) |
gilescope
added
A0-please_review
gilescope
commented
Sep 13, 2021
bkchr
reviewed
Sep 13, 2021
… into giles-use-ss58-crate
|
Ah ok. Will have to be two crates then - an |
|
Tempted to rename |
gilescope
changed the title
gui1117
reviewed
Sep 23, 2021
bkchr
reviewed
Oct 4, 2021
KiChjang
reviewed
Oct 6, 2021
bkchr
reviewed
Oct 6, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
… into giles-use-ss58-crate
|
finally. @bkchr I think the only thing it needs now is an approval on the companion PR. |
bkchr
approved these changes
Oct 11, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
andresilva
approved these changes
Oct 11, 2021
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
|
Will merge this in tomorrow morning. |
|
Shouldn't |
done in #10094 |
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ss58 json and enum definition into its own crate. Fixes #9696
Changes:
Default using atomic rather than a mutex.
u8/u16 conversions are From rather than TryFrom as they are infallible due to the Custom(u16) arm of the enum.
O(ln(n)) rather than O(n) perf for lookup methods.
No way to have a custom representation and a known representation that seem unequal but are eq.
Memory size is now the same size as u16 (was twice that).
(See also paritytech/ss58-registry#8 and companion: paritytech/polkadot#3953 )