Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP-7696] Storage: generate_signed_url API documentation misleading for response_type/disposition #11

Conversation

HemangChothani
Copy link
Collaborator

@HemangChothani HemangChothani commented Jul 29, 2019

Fixes #7696

storage/google/cloud/storage/_signing.py Outdated Show resolved Hide resolved
storage/google/cloud/storage/blob.py Outdated Show resolved Hide resolved
@mf2199 mf2199 changed the title Storage: Fix misleading document of signed url /7696 [GCP-7696] Storage: generate_signed_url API documentation misleading for response_type/disposition Jul 31, 2019
@mf2199 mf2199 marked this pull request as ready for review August 5, 2019 20:35
@mf2199
Copy link
Collaborator

mf2199 commented Aug 5, 2019

As we've reached a consensus, it's time to close this one and open a public PR for that matter.

@mf2199 mf2199 closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage: generate_signed_url API documentation misleading for response_type/disposition
4 participants