Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP-7696] Storage: generate_signed_url API documentation misleading for response_type/disposition #11

Closed
wants to merge 3 commits into from
Closed

[GCP-7696] Storage: generate_signed_url API documentation misleading for response_type/disposition #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd84924
edit document of signed url
HemangChothani Jul 29, 2019
04403d1
add whitespace between sentances
HemangChothani Jul 31, 2019
e0e059c
cosmetic changes
HemangChothani Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions storage/google/cloud/storage/_signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,7 @@ def generate_signed_url_v2(

:type response_type: str
:param response_type: (Optional) Content type of responses to requests for
the signed URL. Used to over-ride the content type of
the underlying resource.
the signed URL.Ignored if content_type is set.
HemangChothani marked this conversation as resolved.
Show resolved Hide resolved

:type response_disposition: str
:param response_disposition: (Optional) Content disposition of responses to
Expand Down
3 changes: 1 addition & 2 deletions storage/google/cloud/storage/blob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,7 @@ def generate_signed_url(

:type response_type: str
:param response_type: (Optional) Content type of responses to requests
for the signed URL. Used to over-ride the content
type of the underlying blob/object.
for the signed URL.Ignored if content_type is set.
HemangChothani marked this conversation as resolved.
Show resolved Hide resolved

:type generation: str
:param generation: (Optional) A value that indicates which generation
Expand Down