Undo temporary changes in all-helpers.sh #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleuzi01
added
enhancement
eleuzi01
force-pushed
the
issue-39-follow-up
branch
from
d39c76f to
7b77689
Compare
This was referenced Dec 10, 2024
eleuzi01
added
needs-review
valeriosetti
previously approved these changes
Dec 13, 2024
| # The configuration option has been removed for 4.0. While the project and | ||
| # branch detection shell in shell work is not completed, just ignore the | ||
| # failure to set MBEDTLS_PSA_CRYPTO_CONFIG. | ||
| scripts/config.py set MBEDTLS_PSA_CRYPTO_CONFIG || true |
There was a problem hiding this comment.
I would keep some comment for future context. People modifying this code need to know this is a 3.6 specific setting.
e.g
MBEDTLS_PSA_CRYPTO_CONFIGis a legacy setting which should only be set on 3.6 LTS branches.
valeriosetti
approved these changes
Dec 18, 2024
minosgalanakis
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
This PR looks good.
I have manually verified that it works with TF-PSA crypto repo. It has been tested againinst development and LTS by the corresponding PR's
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
eleuzi01
force-pushed
the
issue-39-follow-up
branch
from
709538c to
5d6cb59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #67 (comment)
Development: Mbed-TLS/mbedtls#9842
3.6: Mbed-TLS/mbedtls#9835