Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo temporary changes in all-helpers.sh #9842

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Undo temporary changes in all-helpers.sh #9842

merged 1 commit into from
Dec 20, 2024

Conversation

eleuzi01
Copy link
Contributor

Description

Resolves Mbed-TLS/mbedtls-framework#67 (comment)

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added enhancement needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) labels Dec 11, 2024
This was referenced Dec 11, 2024
Merged
Merged
@eleuzi01 eleuzi01 removed the needs-ci Needs to pass CI tests label Dec 12, 2024
valeriosetti
valeriosetti previously approved these changes Dec 13, 2024
View reviewed changes
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon needs-work needs-backports Backports are missing or are pending review and approval. labels Dec 19, 2024
@eleuzi01
Update submodule
42f0e76 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
minosgalanakis
minosgalanakis approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minosgalanakis minosgalanakis added needs-ci Needs to pass CI tests and removed needs-backports Backports are missing or are pending review and approval. needs-reviewer This PR needs someone to pick it up for review labels Dec 20, 2024
@minosgalanakis
Copy link
Contributor

The ABI failures are unrelated to the current PR and an effect of some other changes #9866 . We will carry on with merging this and the backport.

@minosgalanakis minosgalanakis added this pull request to the merge queue Dec 20, 2024
Merged via the queue into Mbed-TLS:development with commit bd4a005 Dec 20, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriosetti valeriosetti valeriosetti approved these changes

@minosgalanakis minosgalanakis minosgalanakis approved these changes

Assignees
No one assigned
Labels
enhancement needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleuzi01 @minosgalanakis @valeriosetti